fix(braintree): give better errors to our users #2490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This parses braintree errors given to us by chargify and displays them for our users
jefflembeck
requested review from
scottjehl,
stoyan and
tkadlec
and removed request for
scottjehl
stoyan
approved these changes
Oct 20, 2022
Contributor
stoyan
left a comment
stoyan
left a comment
There was a problem hiding this comment.
sweet!
Maybe in a follow up we can make braintree-error-parser.js a module and load on demand in the event listener?
Comment on lines
+435
to
+436
| var regExp = /\(([^)]+)\)/; | ||
| var errorCode = regExp.exec(errorText); |
tkadlec
approved these changes
Oct 21, 2022
Contributor
tkadlec
left a comment
tkadlec
left a comment
There was a problem hiding this comment.
LGTM.
We should definitely work on more user-friendly alternatives to the messaging for some of these, but let's get this out so at least we have more actionable information and then we can massage that after.
Contributor
Author
|
Yeah, i'm going to fix this up today. Will get this in and will make it nicer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This parses braintree errors given to us by chargify and displays them for our users