Skip to content

feat(global): add autoEnable and make enable = false disable all modules#817

Open
ThinkChaos wants to merge 2 commits intocatppuccin:mainfrom
ThinkChaos:feat/enable-as-killswitch
Open

feat(global): add autoEnable and make enable = false disable all modules#817
ThinkChaos wants to merge 2 commits intocatppuccin:mainfrom
ThinkChaos:feat/enable-as-killswitch

Conversation

@ThinkChaos
Copy link
Copy Markdown

Fixes #796

@isabelroses
Copy link
Copy Markdown
Member

currently unless we just break every single module. we should also check the stateVersion something roughly like if lib.versionAtLeast catppuccinLib.getModuleRelease "26.05" then cfg.enable && config.catppuccin.enable else cfg.enable

@ThinkChaos ThinkChaos force-pushed the feat/enable-as-killswitch branch from 4c8dffd to cd18a67 Compare January 7, 2026 03:50
@ThinkChaos
Copy link
Copy Markdown
Author

Based on your other comment I thought that would be enough :/
I'll add the versionAtLeast check tomorrow!

(I rebased on main)

@isabelroses
Copy link
Copy Markdown
Member

Based on your other comment I thought that would be enough :/ I'll add the versionAtLeast check tomorrow!

Yeah i thought this too. Then I realised when i actually saw the code 😭. Thanks again for working on this.

@ThinkChaos
Copy link
Copy Markdown
Author

No worries! I think I can use an attr under config.lib.catppuccin to make it easier :)

@ThinkChaos
Copy link
Copy Markdown
Author

I pushed a couple commits, the most interesting one being 776acb4 which should do what you were describing, just in a central place to keep modules simpler :)

@ThinkChaos ThinkChaos force-pushed the feat/enable-as-killswitch branch from 997b70f to 2f32bf1 Compare January 8, 2026 00:06
@ThinkChaos ThinkChaos force-pushed the feat/enable-as-killswitch branch from 1d3f86f to 7167c94 Compare January 8, 2026 00:17
@ThinkChaos ThinkChaos marked this pull request as ready for review January 8, 2026 00:21
@isabelroses isabelroses requested a review from getchoo January 16, 2026 14:59
@ThinkChaos
Copy link
Copy Markdown
Author

Hey, any further comments? :)

@isabelroses
Copy link
Copy Markdown
Member

I'm mostly good with it I did want @getchoo to take a look before going forwards but they seem quite busy as of recent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

catppuccin.enable = false doesn't disable everything

2 participants