Add support from reading from jimfs in-memory FS#60
Merged
cdimascio merged 1 commit intocdimascio:masterfrom Dec 25, 2023
clintval:cv_jimfs_support
Merged
Add support from reading from jimfs in-memory FS#60cdimascio merged 1 commit intocdimascio:masterfrom clintval:cv_jimfs_support
cdimascio merged 1 commit intocdimascio:masterfrom
clintval:cv_jimfs_support
Conversation
Owner
|
Can you provide some background on the addition of jimfs. What is the use case and benefit of this change? |
Contributor
Author
|
@cdimascio it's far from a critical feature for me. I wanted to use an in-memory file system for Groovy unit tests so I wouldn't have to write files in my temp directory. You can see that here: I'm using your library under-the-hood of a plugin I developed for a scientific workflow manager. Instead, I implemented my testing with real temporary files on a real filesystem. |
Contributor
Author
|
This is the project that uses your library: |
cdimascio
approved these changes
Dec 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #59
Draft PR to use upstream's CI harness to make sure this works OK.
@cdimascio have any ideas for how I could test this?