Revert on estimate if destination is not setup#702
Merged
Conversation
|
Coverage after merging revert-on-estimate into main will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
wischli
approved these changes
Oct 7, 2025
lemunozm
reviewed
Oct 7, 2025
| } | ||
|
|
||
| function testEstimate(uint64 gasLimit) public view { | ||
| function testEstimate(uint64 gasLimit) public { |
Contributor
There was a problem hiding this comment.
NIT, could we add testErrUnknownChainId cases?
Contributor
Author
There was a problem hiding this comment.
Let's do in followup PR, I think in general the adapter tests can be improved a bit.
Contributor
There was a problem hiding this comment.
I was thinking that maybe we can build some generic adapter test that acts over IAdapter and IAdapterWiring. So you only need to mock your specific adapter calls to some generic expected behavior and run this generic adapter tests for your new adapter implementation
Contributor
Author
There was a problem hiding this comment.
Interesting idea, makes sense to me yes!
gpmayorga
pushed a commit
that referenced
this pull request
Oct 8, 2025
hieronx
added a commit
that referenced
this pull request
Oct 17, 2025
* First try at recovering #678 * deployed sepolia and arbitrum sepolia * take a stab at wire adapters (still failing) * Move message related files to core/messages (#698) * move message files * fix fmt * Revert on estimate if destination is not setup (#702) * ci: add ward check script (#696) * ci: add ward check script * fix: script relative dir * ci: move ward coverage to ci.yml as optional check * ci: make ward coverage check mandatory * tests: add missing ward coverage * Tests: Change `vm.assume` to `bound`s (#705) * Change vm.assume calls to bounds * Format * fix: uninitialized network multiAdapter views * apply suggestion from code review & fmt * ref: move _getFirstAdapterDetails to bottom * chore: update benches * All contracts for Sepolia networks deployed and verified * Ensure salt also applied to root contract * small python deployment fixes * Add cancelation flow to test data (#709) * improve batch docs (#706) * Add cancelation flow to test data * Fix build --------- Co-authored-by: Luis Enrique Muñoz Martín <lemunozm@gmail.com> Co-authored-by: Guillermo Perez <gpmayorga@users.noreply.github.com> * new wireadapters with some safeguards for asymmetrical adapter configs * correct Eid for layerzero * Modular test scripts and cross chain tests * Fix Hub tests * address PR comment * Updated testnets deployment * latest wireadapters * fix e2e hub-spoke tests for sepolia testnets * commit missing test shared methods * Implement ReleaseManager for orchestrated Sepolia testnet deployments and enhance argument validation in deploy script * Update .gitignore to exclude .env.back and JSON files in the anvil directory * cleanup and refactor some var names * Remove gas buffer percentage in adapters * Increase base cost to 50k * Update adapter configurations and deployment scripts for Sepolia. Removed deprecated adapter addresses, added new ones, and introduced a new script for deploying only messaging adapters. Enhanced deployment validation and added support for deploying adapters separately. * pseudo-random pool index selection with environment variable override, ensuring valid index range (100-999) * sepolia & base sepolia redeploy * deployed arbitrum sepolia * New deployment features (anvil still buggy) * git ignore anvil files * Add cross-chain vault deployment functionality - Introduced `XcAsyncVaultParams` and `XcSyncVaultParams` structs for cross-chain vault configurations. - Implemented `deployAsyncVaultXc` and `deploySyncDepositVaultXc` functions to handle cross-chain vault deployments. * fixed import order * Fix imports unused * fixed import CI check * fixed CI checks * Add readme to test folder and move testdata * Moved test files * moved test files under /test/ * Revert anvil.py changes - moved to separate PR * Update import paths * Fix TestData script path for anvil deployment * Format, benchmarks * Fix * Move * Fix typo * Disable sync vault redemption * Add whitelisting * Fix typo --------- Co-authored-by: Luis Enrique Muñoz Martín <lemunozm@gmail.com> Co-authored-by: Jeroen <1748621+hieronx@users.noreply.github.com> Co-authored-by: William Freudenberger <w.freude@icloud.com> Co-authored-by: Jeroen Offerijns <git@o6ns.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Product requirements
estimatemethod of adapters should revert