Open
Conversation
CDB-2128 Nonce errors in Clay AND QA CAS
Coordinator: dbrowning Investigator: dbrowning Clay CAS: QA CAS: |
ukstv
reviewed
May 17, 2023
| txHash: string | ||
| blockNumber: number | ||
| blockTimestamp: number | ||
| blockNumber: bigint |
Contributor
There was a problem hiding this comment.
Mind if I ask you what happened to the timestamp?
Author
There was a problem hiding this comment.
It's not part of the transaction receipt from viem. Still need to figure out if there's a way for me to get that. Possibly by grabbing the block.
ukstv
reviewed
May 17, 2023
|
|
||
| constructor(config: Config, private readonly wallet: ethers.Wallet) { | ||
| this.useSmartContractAnchors = config.useSmartContractAnchors | ||
| constructor(config: Config, private readonly provider: PublicClient, private readonly wallet: WalletClient, private readonly walletAddress: Address) { |
Contributor
There was a problem hiding this comment.
It is safer IMO to not mix private readonly constructor properties with property declarations like on 161-166. It makes it complicated to see what is actually available. IMO.
Contributor
|
Hey @dbcfd any news on the PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.