fix: only instantiate contract if contract address given#885
fix: only instantiate contract if contract address given#885stephhuynh18 wants to merge 1 commit intodevelopfrom
Conversation
Codecov ReportBase: 85.27% // Head: 85.17% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #885 +/- ##
===========================================
- Coverage 85.27% 85.17% -0.10%
===========================================
Files 26 26
Lines 1297 1302 +5
Branches 190 194 +4
===========================================
+ Hits 1106 1109 +3
- Misses 191 193 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
v-stickykeys
left a comment
v-stickykeys
left a comment
There was a problem hiding this comment.
The error handling here seems a bit redundant and hard to follow.
Can we simplify to just
If usesmartcontractanchors { if contractaddress {...} else { throw } }
@v-stickykeys yes it is =( I was being lazy HAHA because of the tests dislikes the option you provided. But i should do it right. |
|
hey @stephhuynh18 should we fix conflicts and merge this during our on-call week? figured cleanup old branches |
| ) | ||
| } | ||
|
|
||
| if (this.config.blockchain.connectors.ethereum.contractAddress) { |
There was a problem hiding this comment.
we don't need this if since we have the throw above? but ya i like the clear error message
4 participants
No description provided.