Skip to content

build(python): add support for Python 3.13#146

Merged
tiborsimko merged 1 commit intocernopendata:masterfrom
tiborsimko:py313
Feb 25, 2025
Merged

build(python): add support for Python 3.13#146
tiborsimko merged 1 commit intocernopendata:masterfrom
tiborsimko:py313

Conversation

@tiborsimko
Copy link
Member

No description provided.

@tiborsimko tiborsimko self-assigned this Dec 18, 2024
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
"Programming Language :: Python :: 3.12",
"Programming Language :: Python :: 3.13",
Copy link
Member Author

@tiborsimko tiborsimko Dec 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: the CI failures for py313 are the same as for py312 and are related to the recent change in the CERN Open Data portal's handling of files attached to records via file indexes.

Test results for Python 3.13:

$ tox -e py313
FAILED tests/test_cli_download_files.py::test_dry_run_from_doi - AssertionError: assert 'CMS_Run2010B_BTau_AOD_Apr21ReReco-v1_0001_file_index.json' in '\n'
FAILED tests/test_cli_get_file_locations.py::test_get_file_locations_from_recid_expand - AssertionError: assert '2A227E10-C949-E311-B033-003048FEAF50.root' in ''
FAILED tests/test_cli_get_file_locations.py::test_get_file_locations_from_recid_expand_verbose - AssertionError: assert '2A227E10-C949-E311-B033-003048FEAF50.root' in ''
FAILED tests/test_cli_get_file_locations.py::test_get_file_locations_from_doi - AssertionError: assert 'CMS_Run2010B_BTau_AOD_Apr21ReReco-v1_0001_file_index.json' in ''
FAILED tests/test_metadater.py::test_get_metadata_from_filter_metadata_two - assert 1 == 0
=============================================================================================== 5 failed, 65 passed, 10 skipped in 7.96s ===============================================================================================
py313: exit 1 (8.22 seconds) cernopendata-client> pytest pid=685218
  py313: FAIL code 1 (14.79=setup[6.57]+cmd[8.22] seconds)
  evaluation failed :( (14.84 seconds)

Test results for Python 3.12:

$ tox -e py312
FAILED tests/test_cli_download_files.py::test_dry_run_from_doi - AssertionError: assert 'CMS_Run2010B_BTau_AOD_Apr21ReReco-v1_0001_file_index.json' in '\n'
FAILED tests/test_cli_get_file_locations.py::test_get_file_locations_from_recid_expand - AssertionError: assert '2A227E10-C949-E311-B033-003048FEAF50.root' in ''
FAILED tests/test_cli_get_file_locations.py::test_get_file_locations_from_recid_expand_verbose - AssertionError: assert '2A227E10-C949-E311-B033-003048FEAF50.root' in ''
FAILED tests/test_cli_get_file_locations.py::test_get_file_locations_from_doi - AssertionError: assert 'CMS_Run2010B_BTau_AOD_Apr21ReReco-v1_0001_file_index.json' in ''
FAILED tests/test_metadater.py::test_get_metadata_from_filter_metadata_two - assert 1 == 0
=============================================================================================== 5 failed, 65 passed, 10 skipped in 7.87s ===============================================================================================
py312: exit 1 (8.15 seconds) cernopendata-client> pytest pid=686540
  py312: FAIL code 1 (12.79=setup[4.64]+cmd[8.15] seconds)
  evaluation failed :( (12.84 seconds)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that #147 has been fixed, the tests are passing:

$ tox -e py313
...
  py313: OK (27.36=setup[6.54]+cmd[20.82] seconds)
  congratulations :) (27.41 seconds)

tiborsimko added a commit to tiborsimko/cernopendata-client that referenced this pull request Dec 18, 2024
@codecov
Copy link

codecov bot commented Feb 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.80%. Comparing base (fef3295) to head (1714dbf).
Report is 9 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #146   +/-   ##
=======================================
  Coverage   80.80%   80.80%           
=======================================
  Files          12       12           
  Lines         719      719           
=======================================
  Hits          581      581           
  Misses        138      138           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tiborsimko tiborsimko merged commit 1714dbf into cernopendata:master Feb 25, 2025
18 checks passed
@tiborsimko tiborsimko deleted the py313 branch February 25, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant