Skip to content

Conversation

@meissadia
Copy link
Contributor

@meissadia meissadia commented Jan 30, 2024

Closes #2076

Changes

Corrections to option content

  • Ethnicity of Co-Applicant or Co-Borrower: 1
    • Add missing option - 5: No-coapplicant
    • Fix layout issues with description (single description is split into multiple)
  • Ethnicity of Co-Applicant or Co-Borrower: 2-5
    • Remove invalid options: 3,4

Updates to schemaGenerator.js auto-generate/support special cases

TS

  • Record Identifier
    • Generate 'disable: true'
  • Total Number of Entries Contained in Submission
    • Generate 'disable: true'
    • Generate tooltip

LAR

  • Credit Score of Applicant or Borrow
    • Support for the Other option, which has a blank string as the associated value

Testing

  1. Compare options for Ethnicity of Co-Applicant or Co-Borrower: 1 - 5 against the FIG
  2. Verify Record Identifier is disabled for both LAR and TS rows
  3. Verify TS Total Number of Entries Contained in Submission is disabled and has the tooltip

Happy to discuss changes

Screenshots

Added option 5 for Ethnicity of Co-Applicant or Co-Borrower: 1

co-app-1-option-5

Removed options 3/4 for Ethnicity of Co-Applicant or Co-Borrower: 2-5

co-app-2-removed-option-3-and-4

- Ethnicity of Co-Applicant or Co-Borrower: 1
  - Add missing option - 5: No-coapplicant
  - Fix layout issues with discription
- Ethnicity of Co-Applicant or Co-Borrower: 2-5
  - Remove invalid options (3,4)
- Fix duplicated text: "this this"
Copy link
Contributor

@Michaeldremy Michaeldremy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great report on what changes are being made! Looks good to me!

Copy link
Contributor

@ojbravo ojbravo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

@ojbravo ojbravo merged commit 7337811 into master Jan 31, 2024
@ojbravo ojbravo deleted the fix-olarft branch January 31, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[OLARFT] Correct Co-Borrow Ethnicity options

4 participants