2244-react-tables #2529
Merged
2244-react-tables #2529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billhimmelsbach
requested changes
May 29, 2025
Contributor
billhimmelsbach
left a comment
billhimmelsbach
left a comment
There was a problem hiding this comment.
It's looking good! I think there's maybe an issue though with the rows not lining up after the update in the Saved Records section:
Old Version
PR Version
Looks like the label row and the values row get a little more out of alignment with each other after each successive column? Maybe a little CSS change is needed there?
Contributor
Author
|
Returned cell padding back to 8px. react-fluid-table's most recent update changed padding to .5rem (5px). Everything lines up correctly again: |
billhimmelsbach
approved these changes
Jun 4, 2025
Contributor
billhimmelsbach
left a comment
billhimmelsbach
left a comment
There was a problem hiding this comment.
I tested out all the things again, re-ran the tests, and everything looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All tests passing on dev. Closes #2244.