Skip to content

Conversation

@contolini
Copy link
Member

@contolini contolini commented Sep 25, 2025

There's a lot of automatic linting fixes, view the diff with whitespace ignored.

Adds an @auth-required tag to cypress tests that require keycloak authentication. Non-auth tests can be run utilizing cypress' grep package by passing --env grepTags='-@auth-required' which is saved as a script called yarn test-non-auth.

I also created a github workflow to run the tests on pull requests.

Fixes #2604

Changes

  • Adds a tag to tests that require authentication to run.
  • Creates an npm script targeting non-auth tests.
  • Adds a github test workflow.

Testing

  1. The brand new pull request workflow below should pass

Notes

  • I'm open to other naming conventions, non-auth is kind of a weird phrase.

Copy link
Contributor

@billhimmelsbach billhimmelsbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This runs great! Tried running it against dev/prod, things looks good, and things look good in the GitHub action logs.

If you wanted my take on "non-auth", I would probably just go with the longer but maybe clearer "unauthenticated"? Totally up to you though and it works great as is. 🚀

@contolini
Copy link
Member Author

@billhimmelsbach I am very grateful that there are native English speakers such as yourself on my team

…entication

To run many of our tests, we have to pass credentials to log into keycloak.
This prevents us from running our tests publicly. By tagging some of our tests
as not requiring authentication, we can run those publicly on pull requests and
reserve auth tests for private execution.

See #2604
@contolini contolini force-pushed the 2604-non-auth-tests branch from f5c1f41 to 8177324 Compare October 7, 2025 01:21
@contolini contolini merged commit 948660e into master Oct 7, 2025
1 check passed
@contolini contolini deleted the 2604-non-auth-tests branch October 7, 2025 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[e2e] Add script to run all e2e tests that don't require auth

3 participants