Time representation difference in Chai.js

[flaambe]

Is it better to change the time representation in loupe or chai.js tests?

  21) should
       most(n) (dates):

      expected 'blah
      + expected - actual

      -blah: expected 2021-01-27T09:34:22.030Z to be at most 2021-01-27T09:34:21.030Z
      +blah: expected Wed, 27 Jan 2021 09:34:22 GMT to be at most Wed, 27 Jan 2021 09:34:21 GMT
      
      at globalErr (test/bootstrap/index.js:52:57)
      at Context.<anonymous> (test/should.js:1128:5)
      at processImmediate (internal/timers.js:461:21)

[keithamus]

Let's change it here - ISO dates lead to less confusion.

[flaambe]

I think you meant in chai, since loupe uses ISO, or I'm wrong?))

[keithamus]

Oh yeah 😅 I was reading it wrong. Let's change chai 😄

[flaambe]

I can't figure out what the problem is:

  5) expect
       within(start, finish) (dates):

      expected 'blah
      + expected - actual

      -blah: expected 2021-01-27T12:03:21.949Z to not be within Wed Jan 27 2021 17:03:21 GMT+0500 (Uzbekistan Standard Time)..Wed Jan 27 2021 17:03:22 GMT+0500 (Uzbekistan Standard Time)
      +blah: expected 2021-01-27T12:03:21.949Z to not be within 2021-01-27T12:03:21.949Z..2021-01-27T12:03:22.949Z
      
      at globalErr (test/bootstrap/index.js:52:57)
      at Context.<anonymous> (test/expect.js:618:5)
      at processImmediate (internal/timers.js:461:21)

[keithamus]

https://github.com/chaijs/chai/blob/23764f340d6d3796eafdb7a9869b423bc45e0c8b/lib/chai/core/assertions.js#L1569

this probably needs to change to something like

range = loupe(start) + '..' + loupe(finish)

There'll likely be a few of these behavioural changes within the code. Part of the motivation for moving to using loupe is to standardise this kind of edge case behaviour.

[flaambe]

@keithamus Yeah, thanks, it worked

At the moment I have 15 failed tests