fix: Correct swap analytics duration measurement#1849
Open
fix: Correct swap analytics duration measurement#1849
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
piatoss3612
reviewed
Feb 24, 2026
…acking Move `requestStartedAtRef.current = undefined` after the logEvent call so that logEvent can use the value when initializing durationRef.first for total_duration_ms calculation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
total_duration_ms가swap_quote_received시점부터만 측정되어 quote 요청 구간(swap_quote_requested→swap_quote_received)이 누락되는 버그 수정.durationRef초기화 시requestStartedAtRef.current를 first로 사용queryRouteForLog객체가 교체되어도isFetching이 true → true로 effect가 재실행되지 않아requestStartedAtRef가 갱신되지 않는 버그 수정.queryRouteForLog객체 참조 변경도 감지하도록 dependency 추가