Skip to content

Remove 1px gap in s size AlphaButton#2484

Merged
yangwooseong merged 2 commits intochannel-io:mainfrom
yangwooseong:WEB-5245/button-text-gap
Nov 6, 2024
Merged

Remove 1px gap in s size AlphaButton#2484
yangwooseong merged 2 commits intochannel-io:mainfrom
yangwooseong:WEB-5245/button-text-gap

Conversation

@yangwooseong
Copy link
Contributor

Self Checklist

  • I wrote a PR title in English and added an appropriate label to the PR.
  • I wrote the commit message in English and to follow the Conventional Commits specification.
  • I added the changeset about the changes that needed to be released. (or didn't have to)
  • I wrote or updated documentation related to the changes. (or didn't have to)
  • I wrote or updated tests related to the changes. (or didn't have to)
  • I tested the changes in various browsers. (or didn't have to)
    • Windows: Chrome, Edge, (Optional) Firefox
    • macOS: Chrome, Edge, Safari, (Optional) Firefox

Related Issue

  • 없음

Summary

  • s 사이즈의 AlphaButton, AlphaFloatingButton에 있는 1px 갭을 제거합니다.

Details

  • 생략

Breaking change? (Yes/No)

  • No

References

@yangwooseong yangwooseong added the fix PR related to bug fix label Nov 5, 2024
@yangwooseong yangwooseong self-assigned this Nov 5, 2024
@changeset-bot
Copy link

changeset-bot bot commented Nov 5, 2024

🦋 Changeset detected

Latest commit: 6a5a455

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@channel.io/bezier-react Patch
bezier-figma-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@channeltalk
Copy link

channeltalk bot commented Nov 5, 2024

@codecov
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.28%. Comparing base (0da271f) to head (6a5a455).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2484   +/-   ##
=======================================
  Coverage   83.28%   83.28%           
=======================================
  Files         141      141           
  Lines        2943     2943           
  Branches      899      899           
=======================================
  Hits         2451     2451           
  Misses        487      487           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2024

Chromatic Report

🚀 Congratulations! Your build was successful!

@yangwooseong yangwooseong merged commit 3a10b33 into channel-io:main Nov 6, 2024
yangwooseong pushed a commit that referenced this pull request Nov 6, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @channel.io/bezier-react@2.4.0

### Minor Changes

- The use client directive has been added at the top of all components
inside @channel.io/bezier-react.
([#2468](#2468)) by
@nayounsang

### Patch Changes

- Remove 1px gap between icon and text in `s` size `AlphaButton`,
`AlphaFloatingButton`.
([#2484](#2484)) by
@yangwooseong

- Apply hovered color token for `AlphaButton`, `AlphaFloatingButton`,
and `AlphaFloatingIconButton`.
([#2471](#2471)) by
@yangwooseong

- Add `ToggleEmojiButtonGroup` and `ToggleEmojiButtonSource` component.
([#2301](#2301)) by
@yangwooseong

-   Updated dependencies
    -   @channel.io/bezier-tokens@0.2.11

## @channel.io/bezier-tokens@0.2.11

### Patch Changes

- Change `alpha-color-green-300-0` alpha token.
([#2471](#2471)) by
@yangwooseong
Modify hovered color generating formula so that they are more visible in
dark theme.

## @channel.io/stylelint-bezier@0.2.5

### Patch Changes

-   Updated dependencies
    -   @channel.io/bezier-tokens@0.2.11

## bezier-figma-plugin@0.6.13

### Patch Changes

-   Updated dependencies
    -   @channel.io/bezier-react@2.4.0

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix PR related to bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants