Skip to content

Add secrets manager integration for credential retrieval #897

Open
alberefe wants to merge 1 commit intochaoss:mainfrom
alberefe:credential-manager-integration
Open

Add secrets manager integration for credential retrieval #897
alberefe wants to merge 1 commit intochaoss:mainfrom
alberefe:credential-manager-integration

Conversation

@alberefe
Copy link
Copy Markdown

Integrate Perceval with external secrets managers (Bitwarden, HashiCorp Vault) so credentials can be resolved at runtime instead of being passed as plain-text CLI arguments.

  • Add --secrets-manager, --item-name, and provider-specific CLI flags
    to BackendCommandArgumentParser
  • Add _pre_init() and _build_manager() in BackendCommand to orchestrate credential resolution via grimoirelab-toolkit's resolve_credentials()
  • Enable secrets manager support on 14 backends
  • Add hvac as optional dependency group
  • Usage in README

@alberefe
Copy link
Copy Markdown
Author

I'll be fixing this later please wait before you check so every test and dependency is working fine!

@alberefe alberefe force-pushed the credential-manager-integration branch 2 times, most recently from b16dbb2 to cc2a73e Compare April 29, 2026 11:56
Copy link
Copy Markdown
Member

@sduenas sduenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my initial comments. Also, my concern is this only makes perceval work if you use the backend command but not the library. Please evaluate if it makes sense to integrate it within fetch or other methods, or if on the other hand, developers should use grimoirelab toolkit instead.

Comment thread perceval/backend.py Outdated
Comment thread perceval/backend.py
@alberefe alberefe force-pushed the credential-manager-integration branch from cc2a73e to 447d0c2 Compare May 3, 2026 17:02
@alberefe alberefe requested a review from sduenas May 3, 2026 17:02
Comment thread perceval/backend.py Outdated
Comment thread perceval/backend.py Outdated
@alberefe alberefe force-pushed the credential-manager-integration branch from 447d0c2 to f8cc53e Compare May 4, 2026 11:54
@alberefe alberefe requested a review from sduenas May 4, 2026 11:54
Copy link
Copy Markdown
Member

@sduenas sduenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the lint errors and add unit test for this functionality.

Signed-off-by: Alberto Ferrer Sánchez <alberefe@gmail.com>
@alberefe alberefe force-pushed the credential-manager-integration branch from f8cc53e to e658562 Compare May 5, 2026 09:20
@alberefe
Copy link
Copy Markdown
Author

alberefe commented May 5, 2026

Getting those errors cause I think it's importing an old version of Toolkit from before it had the las PR changes, is that correct? Not sure how to deal with that or if I'm even correct, but not sure what to do with it.

@sduenas
Copy link
Copy Markdown
Member

sduenas commented May 5, 2026

Getting those errors cause I think it's importing an old version of Toolkit from before it had the las PR changes, is that correct? Not sure how to deal with that or if I'm even correct, but not sure what to do with it.

We fixed it in #900. Please rebase your branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants