Add secrets manager integration for credential retrieval #897
Add secrets manager integration for credential retrieval #897alberefe wants to merge 1 commit intochaoss:mainfrom
Conversation
|
I'll be fixing this later please wait before you check so every test and dependency is working fine! |
b16dbb2 to
cc2a73e
Compare
sduenas
left a comment
There was a problem hiding this comment.
Please check my initial comments. Also, my concern is this only makes perceval work if you use the backend command but not the library. Please evaluate if it makes sense to integrate it within fetch or other methods, or if on the other hand, developers should use grimoirelab toolkit instead.
cc2a73e to
447d0c2
Compare
447d0c2 to
f8cc53e
Compare
sduenas
left a comment
There was a problem hiding this comment.
Please fix the lint errors and add unit test for this functionality.
Signed-off-by: Alberto Ferrer Sánchez <alberefe@gmail.com>
f8cc53e to
e658562
Compare
|
Getting those errors cause I think it's importing an old version of Toolkit from before it had the las PR changes, is that correct? Not sure how to deal with that or if I'm even correct, but not sure what to do with it. |
We fixed it in #900. Please rebase your branch. |
Integrate Perceval with external secrets managers (Bitwarden, HashiCorp Vault) so credentials can be resolved at runtime instead of being passed as plain-text CLI arguments.
to BackendCommandArgumentParser