Backport: fix(cmd): respect SetStdin/SetStdout/SetStderr for tea.Exec compatibility#524
Open
puneet-chandna wants to merge 1 commit intocharmbracelet:v2-expfrom
Open
Backport: fix(cmd): respect SetStdin/SetStdout/SetStderr for tea.Exec compatibility#524puneet-chandna wants to merge 1 commit intocharmbracelet:v2-expfrom
puneet-chandna wants to merge 1 commit intocharmbracelet:v2-expfrom
Conversation
- Use xpty.WaitProcess on Windows for proper ConPTY waiting - Implement SetStdin/SetStdout/SetStderr to store and use custom I/O - Require all stdio to be set for custom path (avoids PTY deadlocks) Fixes charmbracelet#506
puneet-chandna
requested review from
aymanbagabas and
kujtimiihoxha
and removed request for
a team
aymanbagabas
approved these changes
Jan 14, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v2-exp #524 +/- ##
=========================================
Coverage ? 75.13%
=========================================
Files ? 21
Lines ? 893
Branches ? 0
=========================================
Hits ? 671
Misses ? 167
Partials ? 55 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR backports the changes from #522 to the v2-exp branch.
It updates wish.Cmd process spawning to use the internal x/xpty library and ensures SetStdin/SetStdout/SetStderr are respected for tea.Exec compatibility.
Fixes #506