chore: change pnpm version in engines field to be able to use 8.x.x#11209
Merged
etimberg merged 4 commits intochartjs:masterfrom Mar 29, 2023
Merged
chore: change pnpm version in engines field to be able to use 8.x.x#11209etimberg merged 4 commits intochartjs:masterfrom
etimberg merged 4 commits intochartjs:masterfrom
Conversation
Collaborator
|
CI seems to fail |
Contributor
Author
|
I guess, I should also change GitHub workflows. |
Collaborator
|
Guess we can't do this in V4 because if we need to update our workflow to version 8 that means it doesn't work with version 7 anymore as specified in the package json and makes this a breaking change |
Contributor
Author
|
Maybe, I should just update the package.json to allow pnpm 8.0.0. The version used in this library can be 7 anyway. |
This reverts commit 32dacab.
Contributor
Author
|
All checks are successful except the size check. The size check script also fails in my local, before making these changes. |
etimberg
approved these changes
Mar 29, 2023
Member
|
Not sure which size is over. I quickly glanced at the output and they all seemed under |
Collaborator
|
Seems there are a few but we can fix that in a sepperate MR
|
LeeLenaleee
approved these changes
Mar 29, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pnpmreleased a new version recently, 8.0.0.Without this change, one get an incompatibility error while installing
chart.js, if s/he upgraded to the latestpnpmversion.This PR includes the changes to use the latest
pnpmversion without getting the error.Resolves #11208.
Note: Didn't change the
packageManagerfield inpackage.jsonyet. If this should be changed also, please let me know.