fix: Add backgroundColor type on CoreScaleOptions#11348
Merged
LeeLenaleee merged 3 commits intochartjs:masterfrom Aug 7, 2023
Mer-cat:mer-cat/fix-background-color-cartesianscale
Merged
fix: Add backgroundColor type on CoreScaleOptions#11348LeeLenaleee merged 3 commits intochartjs:masterfrom Mer-cat:mer-cat/fix-background-color-cartesianscale
LeeLenaleee merged 3 commits intochartjs:masterfrom
Mer-cat:mer-cat/fix-background-color-cartesianscale
Conversation
Mer-cat
changed the title
LeeLenaleee
approved these changes
Jun 14, 2023
LeeLenaleee
requested changes
Jun 14, 2023
Collaborator
LeeLenaleee
left a comment
LeeLenaleee
left a comment
There was a problem hiding this comment.
Since it applies to all scales it would be better to move it to the CoreScaleOptions so it is not duplicate
Mer-cat
changed the title
Contributor
Author
|
Can you let me know if there is anything to further change here? Would love to have the corrected type merged :) Thanks! |
Collaborator
|
MB for the late response, since its now in the core scale opts it can be removed from the |
LeeLenaleee
approved these changes
Jul 25, 2023
etimberg
approved these changes
Jul 25, 2023
Contributor
Author
|
I don't have merge permissions, so if you would like to merge this please do. Thanks for your approvals :) |
Member
|
@Mer-cat we'll merge once we release a 4.3.3 to fix a bug |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Very similar to issue #11082 with same fix,
but inadded toCartesianScaleOptionsCoreScaleOptionsso this isn't duplicated in various extensions of theCoreScaleOptions