types: Allow passing undefined for chart options#11780
Merged
etimberg merged 1 commit intochartjs:masterfrom May 21, 2024
jdufresne:options-undefined
Merged
types: Allow passing undefined for chart options#11780etimberg merged 1 commit intochartjs:masterfrom jdufresne:options-undefined
etimberg merged 1 commit intochartjs:masterfrom
jdufresne:options-undefined
Conversation
When exactOptionalPropertyTypes, TypeScript distinguishes between the value undefined and the property not existing. See: https://www.typescriptlang.org/tsconfig/#exactOptionalPropertyTypes For Chart.js options, this difference is not important and either passing undefined or not including it have the same effect.
LeeLenaleee
approved these changes
May 21, 2024
etimberg
approved these changes
May 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When exactOptionalPropertyTypes, TypeScript distinguishes between the value undefined and the property not existing. See:
https://www.typescriptlang.org/tsconfig/#exactOptionalPropertyTypes
For Chart.js options, this difference is not important and either passing undefined or not including it have the same effect.