Skip to content

Refactor startHammer#455

Merged
kurkle merged 5 commits intochartjs:masterfrom
kurkle:refactor-hammer
Apr 17, 2021
Merged

Refactor startHammer#455
kurkle merged 5 commits intochartjs:masterfrom
kurkle:refactor-hammer

Conversation

@kurkle
Copy link
Copy Markdown
Member

@kurkle kurkle commented Apr 16, 2021

  • split startHammer into three parts
  • remove the _ghostClickHandler that would mask the click event on pan end of the canvas
    • this must have somehow been inserted before chart event listeners in v2
    • add similar logic in beforeEvent to mask the click

Resolves: #441

@kurkle kurkle added this to the 1.0.0 milestone Apr 16, 2021
@kurkle kurkle merged commit b7bd3e2 into chartjs:master Apr 17, 2021
@kurkle kurkle deleted the refactor-hammer branch April 26, 2021 14:56
@kurkle kurkle linked an issue Apr 27, 2021 that may be closed by this pull request
@Koxx3
Copy link
Copy Markdown

Koxx3 commented May 26, 2023

hello,
sorry, but I still struggle with scrolling pages with chartjs & zoom plugin.
can you explain the important options to enable page scrolling (and allow pinch zoom) please ?

@marttheis
Copy link
Copy Markdown

Hello,

I am also still having the problem that scroll gestures are eaten by chartjs when done on the chart. I am using
Chartjs 4.3.0
zoom plugin 2.0.1
hammerjs 2.08

It doesn't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

resetzoom triggering after drag (beta) Unable to scroll page on mobile phone even after disabling zoom

3 participants