Use static offsets for panning rounded time scale#474
Merged
kurkle merged 1 commit intochartjs:masterfrom Apr 28, 2021
Merged
Conversation
jledentu
approved these changes
Apr 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #388
The time scale rounds down. So when the max goes some amount less than a day over the
max, it is rounded down and thus the scale is not changed. On the other hand if we go just a millisecond lower thanmin, it is immediately changed by a full day.This adds
offsetbased on the round value, to halfway of the round. So in thedaycase, 12 hours is added to the min/max before applying the delta.This alone is not enough, because if the move is not big enough, then there is no change and the delta is reset.
=> Cumulative delta is stored in state until a change occurs.