Add the ability to enable both wheel and drag modes at the same time#507
Add the ability to enable both wheel and drag modes at the same time#507kurkle merged 9 commits intochartjs:masterfrom
Conversation
|
Nice! |
|
Oh you're right, I admit that I often forget to check touch behaviors. Do I add |
|
I think Edit: Other option would be to add a warning when |
|
@kurkle I added |
etimberg
left a comment
There was a problem hiding this comment.
Two very minor comments. Looks great!
Hi,
Here is a PR thats adds the ability to enable both wheel and drag modes at the same time, as suggested in #239. I propose to split the wheel/drag configurations like this:
speed,threshold,wheelModifierKey(nowwheel.modifierKey) are moved to their respective configurations, I think that makes clearer that a given option refers to a given mode.