Modify UpdateModeEnum to not be const#736
Conversation
|
The change in Chart.js was technically breaking, since the Typescript types in any plugin could not have matched anymore. So bundled with the latest Chart.js version I wouldn't consider this a breaking change. With this change the code does however no longer work with any previous version of Chart.js except for those before the addition of the enum. |
|
What are the exact versions of Chart.js that should work before and after the change? I mean when importing both Chart.js and zoom plugin in a project |
|
I got it running with the following versions: |
|
I would say that based on https://github.com/chartjs/chartjs-plugin-zoom/pull/695/files#diff-093ad82a25aee498b11febf1cdcb6546e4d223ffcb49ed69cc275ac27ce0ccce 2.0.0 of this library introduced |
|
CI fails because of FF, fix is same as in Chart.js: https://github.com/chartjs/Chart.js/pull/11165/files |
|
Hey! Do you guys have any prediction of when this will be merged? Thank you! |
Closes #735
Closes #721
Closes #731
This enum was changed to a normal enum instead of using const in chartjs/Chart.js#11095, so the type is no longer matching with Chart.js.