Skip to content

fix(typing): AttrFunction#1669

Merged
fb55 merged 3 commits intocheeriojs:mainfrom
maxma241:main
Jan 12, 2021
Merged

fix(typing): AttrFunction#1669
fb55 merged 3 commits intocheeriojs:mainfrom
maxma241:main

Conversation

@maxma241
Copy link
Contributor

code snippet
https://github.com/cheeriojs/cheerio/blob/main/lib/api/attributes.js#L113

value.call(el, i, el.attribs[name])

the first argument is thisArg not the function args

@fb55 fb55 merged commit 5f2e9c3 into cheeriojs:main Jan 12, 2021
@fb55
Copy link
Member

fb55 commented Jan 12, 2021

Nice find, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants