Fix: Make .attr() remove attributes when value is undefined#5072
Open
veeceey wants to merge 1 commit intocheeriojs:mainfrom
Open
Fix: Make .attr() remove attributes when value is undefined#5072veeceey wants to merge 1 commit intocheeriojs:mainfrom
veeceey wants to merge 1 commit intocheeriojs:mainfrom
Conversation
Previously, .attr('foo', undefined) would not remove the attribute,
while .attr('foo', null) would. This inconsistency has been fixed
to match jQuery's behavior where both null and undefined remove
the attribute.
Changes:
- Updated setAttr() to handle both null and undefined values
- Changed attr() implementation to use arguments.length check
instead of value !== undefined to properly detect when
undefined is explicitly passed as an argument
- Updated TypeScript type signatures to include undefined
- Added comprehensive tests for undefined attribute removal
Fixes cheeriojs#3307
Author
|
Friendly ping - any chance someone could take a look at this when they get a chance? Happy to make any changes if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3307 -
.attr('foo', undefined)now removes the attribute, matching the behavior of.attr('foo', null).Previously, setting an attribute to
undefinedwould not remove it, while setting it tonullwould. This was inconsistent with jQuery's behavior and user expectations.Changes
setAttr()function to handle bothnullandundefinedvaluesattr()implementation to usearguments.lengthcheck instead ofvalue !== undefinedto properly detect when undefined is explicitly passedundefinedin the value parameterTest Results
All 129 tests pass, including 3 new tests that verify:
Manual Testing
Verified the fix with the exact code from the issue report - both
nullandundefinednow correctly remove attributes.