Conversation
chenasraf
force-pushed
the
fix/output-dir
branch
2 times, most recently
from
1862356 to
da9b1e8
Compare
chenasraf
force-pushed
the
fix/output-dir
branch
from
da9b1e8 to
a605231
Compare
swcarter007
reviewed
Oct 23, 2024
| export async function parseConfigFile(config: ScaffoldCmdConfig): Promise<ScaffoldConfig> { | ||
| let output: ScaffoldConfig = { | ||
| name: config.name, | ||
| templates: [], |
There was a problem hiding this comment.
It appears this change may have broken the templates. Previously, if a user defined a template, it would pass through with the parsed config, but afterward the templates is being reset to an empty array, so its not matching on any files.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Owner
Author
There was a problem hiding this comment.
Created a new issue to track this regression
Let's continue communication there so it's easier to track
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #107