Skip to content

Get data from url asynchronously#64

Merged
christopherdro merged 2 commits intochristopherdro:masterfrom
magrinj:magrinj-patch-1
Oct 1, 2019
Merged

Get data from url asynchronously#64
christopherdro merged 2 commits intochristopherdro:masterfrom
magrinj:magrinj-patch-1

Conversation

@magrinj
Copy link
Copy Markdown
Contributor

@magrinj magrinj commented Dec 6, 2018

Actually if you pass a url to Print the collection of data is done synchronously, so the app is in freeze mode, you can't even print a spinner.
This PR solve this issue by handling the data of the url asynchronously.
It's been a long time since I program in objective C, so I think that can be optimised, but it work!

@magrinj
Copy link
Copy Markdown
Contributor Author

magrinj commented Oct 1, 2019

@christopherdro Maybe you can take a look here please ! :)
My PR was create not far from one year ago

I update it to the lastest release

@christopherdro
Copy link
Copy Markdown
Owner

Thanks! Sorry for the delay here.

@christopherdro christopherdro merged commit c49537e into christopherdro:master Oct 1, 2019
@magrinj
Copy link
Copy Markdown
Contributor Author

magrinj commented Oct 1, 2019

No worries, thanks for the merge ! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants