[BUG] Use the right path for my_member_id in rust-log-service. #4652
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I bumped to two replicas and observed the log of the second one say this: From the log: my_member_id: rust-log-service-1
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
Contributor
|
This PR corrects the environment variable in the Kubernetes manifest for rust-log-service to use CHROMA_LOG_SERVICE__MY_MEMBER_ID instead of the incorrect CHROMA_QUERY_SERVICE__MY_MEMBER_ID. The Helm chart version is also bumped from 0.1.42 to 0.1.43. This summary was automatically generated by @propel-code-bot |
|
✅ The Helm chart's version was changed. Your changes to the chart will be published upon merge to |
Inventrohyder
pushed a commit
to Inventrohyder/chroma
that referenced
this pull request
Aug 5, 2025
…a-core#4652) ## Description of changes This PR properly sets my_member_id for rust-log-service nodes. ## Test plan I bumped to two replicas and observed the log of the second one say this: From the log: my_member_id: rust-log-service-1 - [X] Tests pass locally with `pytest` for python, `yarn test` for js, `cargo test` for rust ## Documentation Changes N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR properly sets my_member_id for rust-log-service nodes.
Test plan
I bumped to two replicas and observed the log of the second one say
this:
From the log: my_member_id: rust-log-service-1
pytestfor python,yarn testfor js,cargo testfor rustDocumentation Changes
N/A