Skip to content

Conversation

@emmanuel-ferdman
Copy link
Contributor

@emmanuel-ferdman emmanuel-ferdman commented May 29, 2025

Description of changes

This small PR resolves the annoying deprecation warnings of the logger library which you can also find in the CI logs:

D:\a\chroma\chroma\chromadb\db\impl\sqlite.py:111: DeprecationWarning: The 'warn' method is deprecated, use 'warning' instead

Test plan

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

@github-actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@propel-code-bot
Copy link
Contributor

This PR updates the deprecated use of logger.warn to logger.warning in chromadb/db/impl/sqlite.py to silence deprecation warnings, as observed in CI logs. It also corrects a few minor typos.

This summary was automatically generated by @propel-code-bot

Copy link
Contributor

@eculver eculver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating!

@HammadB HammadB merged commit 93659ae into chroma-core:main Jun 10, 2025
57 of 72 checks passed
Inventrohyder pushed a commit to Inventrohyder/chroma that referenced this pull request Aug 5, 2025
## Description of changes
This small PR resolves the annoying deprecation warnings of the `logger`
library which you can also find in the [CI
logs](https://github.com/chroma-core/chroma/actions/runs/15312492452):
```python
D:\a\chroma\chroma\chromadb\db\impl\sqlite.py:111: DeprecationWarning: The 'warn' method is deprecated, use 'warning' instead
```

## Test plan

- [x] Tests pass locally with `pytest` for python, `yarn test` for js,
`cargo test` for rust

## Documentation Changes

Signed-off-by: Emmanuel Ferdman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants