Skip to content

Conversation

@rescrv
Copy link
Contributor

@rescrv rescrv commented May 30, 2025

Description of changes

One path is timing out in staging. Add tolerance for that and some
debugging.

Test plan

Compiles

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?

One path is timing out in staging.  Add tolerance for that and some
debugging.
@github-actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@propel-code-bot
Copy link
Contributor

propel-code-bot bot commented May 30, 2025

Enhance Error Tolerance for Log Compaction Path

This PR improves the robustness of the log compaction path in grpc_log.rs by updating error handling. Instead of failing immediately upon encountering an error while fetching collection info for compaction, the implementation now logs each error, continues processing other clients or requests, and only fails the operation if no successful responses are obtained.

Key Changes:
• Replaced early error return with error aggregation in _get_collections_with_new_data.
• Logged errors encountered during collection info fetching instead of immediate failure.
• Proceed with available partial results unless all sub-requests fail, in which case the aggregated error is returned.
• Introduced additional debug logging for failed requests.

Affected Areas:
• rust/log/src/grpc_log.rs
• Log compaction and collection info retrieval logic

This summary was automatically generated by @propel-code-bot

@rescrv rescrv merged commit e46b4a2 into main May 30, 2025
71 checks passed
@rescrv rescrv deleted the rescrv/to branch May 30, 2025 02:37
Inventrohyder pushed a commit to Inventrohyder/chroma that referenced this pull request Aug 5, 2025
…ma-core#4677)

## Description of changes

One path is timing out in staging.  Add tolerance for that and some
debugging.

## Test plan

Compiles

- [x] Tests pass locally with `pytest` for python, `yarn test` for js,
`cargo test` for rust

## Documentation Changes

_Are all docstrings for user-facing APIs updated if required? Do we need
to make documentation changes in the [docs
section](https://github.com/chroma-core/chroma/tree/main/docs/docs.trychroma.com)?_
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants