-
Notifications
You must be signed in to change notification settings - Fork 2k
[CHORE] unpin fastapi, move to dev dependency #4706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
This PR unpins the FastAPI version and relocates both This summary was automatically generated by @propel-code-bot |
382256d to
f0fa186
Compare
f0fa186 to
96ce6bf
Compare
pyproject.toml
Outdated
|
|
||
| [project.optional-dependencies] | ||
| dev = ['chroma-hnswlib==0.7.6'] | ||
| dev = ['chroma-hnswlib==0.7.6', 'fastapi>=0.115.9'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[ArchitectureDecision]
Moving fastapi from dependencies to optional-dependencies suggests making it a development-only dependency. However, based on the imports in the project (like opentelemetry-instrumentation-fastapi), FastAPI appears to be a runtime dependency for the main package functionality. You may want to keep a minimum version of FastAPI in the main dependencies while providing the specific version in dev dependencies for testing purposes.
96ce6bf to
f99279e
Compare
## Description of changes Unpins fastapi and moves to dev dependency. only use of it is in python fastapi server. chroma-core#4243 ## Test plan _How are these changes tested?_ - [ ] Tests pass locally with `pytest` for python, `yarn test` for js, `cargo test` for rust ## Documentation Changes _Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the [docs section](https://github.com/chroma-core/chroma/tree/main/docs/docs.trychroma.com)?_

Description of changes
Unpins fastapi and moves to dev dependency. only use of it is in python fastapi server.
#4243
Test plan
How are these changes tested?
pytestfor python,yarn testfor js,cargo testfor rustDocumentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?