Skip to content

Conversation

@jairad26
Copy link
Contributor

@jairad26 jairad26 commented Jun 2, 2025

Description of changes

Unpins fastapi and moves to dev dependency. only use of it is in python fastapi server.
#4243

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?

@github-actions
Copy link

github-actions bot commented Jun 2, 2025

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

Copy link
Contributor Author

jairad26 commented Jun 2, 2025

@jairad26 jairad26 marked this pull request as ready for review June 2, 2025 16:45
@propel-code-bot
Copy link
Contributor

propel-code-bot bot commented Jun 2, 2025

This PR unpins the FastAPI version and relocates both fastapi and opentelemetry-instrumentation-fastapi from core dependencies to development dependencies. Corresponding changes are made to pyproject.toml, requirements.txt, and requirements_dev.txt to reflect this refactoring, making FastAPI only available in dev and local development environments.

This summary was automatically generated by @propel-code-bot

@jairad26 jairad26 force-pushed the jai/remove-fastapi-dep branch from 382256d to f0fa186 Compare June 2, 2025 16:47
@jairad26 jairad26 force-pushed the jai/remove-fastapi-dep branch from f0fa186 to 96ce6bf Compare June 2, 2025 16:57
pyproject.toml Outdated

[project.optional-dependencies]
dev = ['chroma-hnswlib==0.7.6']
dev = ['chroma-hnswlib==0.7.6', 'fastapi>=0.115.9']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ArchitectureDecision]

Moving fastapi from dependencies to optional-dependencies suggests making it a development-only dependency. However, based on the imports in the project (like opentelemetry-instrumentation-fastapi), FastAPI appears to be a runtime dependency for the main package functionality. You may want to keep a minimum version of FastAPI in the main dependencies while providing the specific version in dev dependencies for testing purposes.

@jairad26 jairad26 force-pushed the jai/remove-fastapi-dep branch from 96ce6bf to f99279e Compare June 2, 2025 17:07
@jairad26 jairad26 merged commit 2849281 into main Jun 2, 2025
72 checks passed
Inventrohyder pushed a commit to Inventrohyder/chroma that referenced this pull request Aug 5, 2025
## Description of changes

Unpins fastapi and moves to dev dependency. only use of it is in python
fastapi server.
chroma-core#4243

## Test plan

_How are these changes tested?_

- [ ] Tests pass locally with `pytest` for python, `yarn test` for js,
`cargo test` for rust

## Documentation Changes

_Are all docstrings for user-facing APIs updated if required? Do we need
to make documentation changes in the [docs
section](https://github.com/chroma-core/chroma/tree/main/docs/docs.trychroma.com)?_
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants