[CHORE] Add pathlib support to path for persistence #4709
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
Contributor
|
This PR enables the use of pathlib.Path objects for the 'path' argument in PersistentClient, allowing both string and Path types for specifying the persistence directory. The implementation ensures that internally all paths are converted to strings before use, improving compatibility with modern Python file APIs. This summary was automatically generated by @propel-code-bot |
jairad26
force-pushed
the
jai/pathlib-support
branch
from
064c2e8 to
eaccbe1
Compare
jairad26
force-pushed
the
jai/pathlib-support
branch
from
eaccbe1 to
dc6d311
Compare
HammadB
approved these changes
Jun 2, 2025
Inventrohyder
pushed a commit
to Inventrohyder/chroma
that referenced
this pull request
Aug 5, 2025
## Description of changes Adds support to pass pathlib.Path for persistence chroma-core#4704 ## Test plan _How are these changes tested?_ - [ ] Tests pass locally with `pytest` for python, `yarn test` for js, `cargo test` for rust ## Documentation Changes _Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the [docs section](https://github.com/chroma-core/chroma/tree/main/docs/docs.trychroma.com)?_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds support to pass pathlib.Path for persistence
#4704
Test plan
How are these changes tested?
pytestfor python,yarn testfor js,cargo testfor rustDocumentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?