[ENH] Tool to inspect the contents of the log. #4757
Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
|
This PR introduces a new Rust binary, This summary was automatically generated by @propel-code-bot |
![propel-code-bot[bot]](https://avatars.githubusercontent.com/in/1179004?s=60&v=4){kind=small}
| async fn main() { | ||
| let args = std::env::args().skip(1).collect::<Vec<_>>(); | ||
| if args.len() != 2 { | ||
| eprintln!("USAGE: chroma-inspect-log-state [HOST] [COLLECTION_UUID]"); |
There was a problem hiding this comment.
[BestPractice]
The error message and command line usage instruction don't match the actual binary name. The error message refers to chroma-inspect-log-state but the binary is named chroma-inspect-log-contents.
| "{} {} {} {}", | ||
| i as usize + j, | ||
| record.log_offset, | ||
| record.record.as_ref().map(|r| r.operation).unwrap_or(4), |
There was a problem hiding this comment.
[BestPractice]
Magic number 4 is used for the default operation. Consider using a named constant or referencing the appropriate enum value to make the code more maintainable and understandable.
Return the keys that are on the log.
rescrv
force-pushed
the
rescrv/inspect-log-contents
branch
from
ba22817 to
fa5645f
Compare
Sicheng-Pan
left a comment
Sicheng-Pan
left a comment
There was a problem hiding this comment.
Remember to update the runbook
## Description of changes Returns the keys that are on the log in order, and the type of log operation. ## Test plan - [X] Tests pass locally with `pytest` for python, `yarn test` for js, `cargo test` for rust ## Documentation Changes N/A
Description of changes
Returns the keys that are on the log in order, and the type of log operation.
Test plan
pytestfor python,yarn testfor js,cargo testfor rustDocumentation Changes
N/A