[TST]: fix concurrency bug in test_cross_version_persist #4770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
codetheweb
commented
Jun 6, 2025
| from typing import Dict, List | ||
|
|
||
| base_install_dir = tempfile.gettempdir() + "/persistence_test_chromadb_versions" | ||
| base_install_dir = ( |
Contributor
Author
There was a problem hiding this comment.
prior to this change, base_install_dir ended up being the same value for all workers spawned by pytest-xdist (which I would not expect), leading to the workers clobbering each other during installs
Contributor
|
This PR updates the test utility for cross-version persistence to resolve a concurrency bug that appeared when running pytest-xdist. The base install directory for versioned package installs is now unique per test worker to prevent concurrent test processes from clobbering each other. This summary was automatically generated by @propel-code-bot |
eculver
approved these changes
Jun 6, 2025
Inventrohyder
pushed a commit
to Inventrohyder/chroma
that referenced
this pull request
Aug 5, 2025
…#4770) ## Description of changes Closes chroma-core#4263. ## Test plan _How are these changes tested?_ - [x] Tests pass locally with `pytest` for python, `yarn test` for js, `cargo test` for rust
This was referenced Aug 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Closes #4263.
Test plan
How are these changes tested?
pytestfor python,yarn testfor js,cargo testfor rust