Skip to content

Conversation

@eculver
Copy link
Contributor

@eculver eculver commented Jun 9, 2025

Description of changes

I had a bad merge when I was resolving conflicts for #4787 at which time, I accidentally disabled the parallelization of one of our tests. This reapplies the parallelization to the right test module.

@eculver eculver requested a review from codetheweb June 9, 2025 22:52
@eculver eculver marked this pull request as ready for review June 9, 2025 22:52
@propel-code-bot
Copy link
Contributor

propel-code-bot bot commented Jun 9, 2025

This PR fixes a CI configuration issue where parallelization was unintentionally removed from the chromadb/test/property/test_add.py test module due to a previous merge conflict. The workflow file is updated to correctly re-enable parallel execution for this module.

This summary was automatically generated by @propel-code-bot

@github-actions
Copy link

github-actions bot commented Jun 9, 2025

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@eculver eculver merged commit 6fbb791 into main Jun 10, 2025
57 checks passed
@eculver eculver deleted the eculver/ci-fix-parallel-test branch June 10, 2025 01:03
Inventrohyder pushed a commit to Inventrohyder/chroma that referenced this pull request Aug 5, 2025
## Description of changes

I had a bad merge when I was resolving conflicts for chroma-core#4787 at which
time, I accidentally disabled the parallelization of one of our tests.
This reapplies the parallelization to the right test module.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants