Skip to content

Conversation

@codetheweb
Copy link
Contributor

@codetheweb codetheweb commented Jun 17, 2025

Description of changes

Bumps the tracing level of chroma-storage to debug from trace.

I audited all spans in rust/storage to ensure all high-frequency code paths only have trace-level events and that any errors are correctly logged with the error level.

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Confirmed that S3 spans no longer show up in Jaeger.

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?

n/a

@github-actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@codetheweb codetheweb marked this pull request as ready for review June 17, 2025 20:16
@codetheweb codetheweb requested a review from sanketkedia June 17, 2025 20:16
@propel-code-bot
Copy link
Contributor

This PR reduces the default verbosity of S3-related tracing by raising the minimum log level for chroma-storage from trace to debug in the tracing filter and by downgrading several S3 operation log messages (info → debug or removal). Adjustments are made in the storage and tracing modules to ensure high-frequency code paths no longer produce excessive span events, with error-level logs retained for failures.

This summary was automatically generated by @propel-code-bot

@codetheweb codetheweb merged commit 4b15315 into main Jun 19, 2025
113 of 115 checks passed
@codetheweb codetheweb deleted the feat-less-verbose-s3-traces branch June 19, 2025 23:44
Inventrohyder pushed a commit to Inventrohyder/chroma that referenced this pull request Aug 5, 2025
## Description of changes

Bumps the tracing level of `chroma-storage` to debug from trace.

I audited all spans in `rust/storage` to ensure all high-frequency code
paths only have trace-level events and that any errors are correctly
logged with the error level.

## Test plan

_How are these changes tested?_

- [x] Tests pass locally with `pytest` for python, `yarn test` for js,
`cargo test` for rust

Confirmed that S3 spans no longer show up in Jaeger.

## Documentation Changes

_Are all docstrings for user-facing APIs updated if required? Do we need
to make documentation changes in the [docs
section](https://github.com/chroma-core/chroma/tree/main/docs/docs.trychroma.com)?_

n/a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants