[BUG] An transient error in scrubbing leads to scrub error. #4898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
Contributor
|
This PR fixes scrub error handling in the log scrubbing logic so that when a manifest/observed scrub mismatch occurs, it returns both the checksum mismatch error and any other collected errors instead of dropping the additional error context. This ensures transient and data errors are surfaced to callers for improved diagnosability. This summary was automatically generated by @propel-code-bot |
Sicheng-Pan
approved these changes
Jun 20, 2025
Sicheng-Pan
reviewed
Jun 20, 2025
Comment on lines
+446
to
+447
| ret.extend(errors); | ||
| Err(ret) |
Contributor
There was a problem hiding this comment.
q: why not errors.push(...) and Err(errors)
Contributor
Author
There was a problem hiding this comment.
I want the overall error first. Would you prefer errors.insert(0, ...)?
Inventrohyder
pushed a commit
to Inventrohyder/chroma
that referenced
this pull request
Aug 5, 2025
…ore#4898) ## Description of changes If there is a transient error on scrub, the error will present as a bad checksum, but the actual error gets dropped. ## Test plan CI ## Documentation Changes N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
If there is a transient error on scrub, the error will present as a bad
checksum, but the actual error gets dropped.
Test plan
CI
Documentation Changes
N/A