Skip to content

Conversation

@Sicheng-Pan
Copy link
Contributor

@Sicheng-Pan Sicheng-Pan commented Sep 18, 2025

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Update default sparse vector populated dimension quota to 4096
  • New functionality
    • N/A

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Migration plan

Are there any migrations, or any forwards/backwards compatibility changes needed in order to make sure this change deploys reliably?

Observability plan

What is the plan to instrument and monitor this change?

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@Sicheng-Pan Sicheng-Pan marked this pull request as ready for review September 18, 2025 01:11
@propel-code-bot
Copy link
Contributor

Update Default Sparse Vector Dimension Quota to 4096

This pull request updates the default quota for UsageType::SparseVectorPopulatedDimensions from 2048 to 4096 in the rust/frontend/src/quota/mod.rs file. There are no related functional changes, new features, or migrations introduced-this is a straightforward configuration update.

Key Changes

• Changed the default value for UsageType::SparseVectorPopulatedDimensions from 2048 to 4096 in the DefaultQuota implementation in rust/frontend/src/quota/mod.rs.

Affected Areas

rust/frontend/src/quota/mod.rs
• Default quota enforcement related to sparse vector dimensions

This summary was automatically generated by @propel-code-bot

@Sicheng-Pan Sicheng-Pan merged commit e1d09d5 into main Sep 23, 2025
61 checks passed
@Sicheng-Pan Sicheng-Pan deleted the 09-17-_chore_update_default_sparse_vector_dimension_quota branch September 23, 2025 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants