Skip to content

Conversation

@jasonvigil
Copy link
Contributor

Description of changes

This isn't really an "error", more of a warning.

Mirroring implementation of similar fix: #5516

Test plan

CI

Migration plan

N/A

Observability plan

Ensure traces are no longer generated for this condition.

Documentation Changes

N/A

This isn't really an "error", more of a warning.
@github-actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@propel-code-bot
Copy link
Contributor

Downgrade NotFound Sparse Index Errors to Warnings (No Trace)

This PR updates error handling for sparse index fetches by introducing a new should_trace_error method in the FetchSparseIndexFilesError enum. The method prevents errors with the ErrorCodes::NotFound code from generating traces, effectively downgrading these occurrences to warnings instead of errors in observability. This follows an established pattern from a related PR to maintain consistency in error classification.

Key Changes

• Added should_trace_error method to FetchSparseIndexFilesError implementation in rust/garbage_collector/src/operators/fetch_sparse_index_files.rs.
• Logic ensures that errors with code ErrorCodes::NotFound return false for should_trace_error, suppressing error tracing for this condition.

Affected Areas

FetchSparseIndexFilesError in rust/garbage_collector/src/operators/fetch_sparse_index_files.rs
• Error handling and tracing for fetch operations involving sparse index files

This summary was automatically generated by @propel-code-bot

Copy link
Contributor

@Sicheng-Pan Sicheng-Pan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. @codetheweb Can you take a look? I assume it is possible to encounter this scenario when the gc is interrupted?

@blacksmith-sh blacksmith-sh bot deleted a comment from jasonvigil Sep 30, 2025
@jasonvigil jasonvigil merged commit 8354492 into main Sep 30, 2025
113 of 116 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants