-
Notifications
You must be signed in to change notification settings - Fork 2k
[ENH] Add keepalive and max conns to python client #5822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
4268f1d to
dabff1a
Compare
|
Expose HTTP keep-alive & connection-limit settings to Python clients Adds three new Key Changes• Introduced Affected Areas• This summary was automatically generated by @propel-code-bot |
dabff1a to
467aae7
Compare
chromadb/test/test_client.py
Outdated
| from chromadb.config import Settings, System | ||
| from chromadb.api import ClientAPI | ||
| import chromadb.server.fastapi | ||
| from chromadb.api.fastapi import FastAPI as SyncFastAPI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason this is renamed?
467aae7 to
7924163
Compare

Description of changes
Summarize the changes made by this PR.
chroma_http_keepalive_secs,chroma_http_max_connections,chroma_http_max_keepalive_connectionsin settings, propagating to fastapi and async fastapi httpx Clients.Test plan
How are these changes tested?
Added tests to ensure settings are persisted, and that the httpx client correctly defines the limits
pytestfor python,yarn testfor js,cargo testfor rustMigration plan
Are there any migrations, or any forwards/backwards compatibility changes needed in order to make sure this change deploys reliably?
Observability plan
What is the plan to instrument and monitor this change?
Documentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?