[BUG] wal3 Sometimes returns an "Internal" when it should return "LogContentionFailure"

[rescrv]

Description of changes

Because of how work gets thrown away during contention, it was possible
for a channel to close and generate an internal error. This casts that
condition to be more descriptive.

Test plan

CI

Migration plan

N/A

Observability plan

N/A

Documentation Changes

N/A

[github-actions]

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

• Can you think of any use case in which the code does not behave as intended? Have they been tested?
• Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
• If appropriate, are there adequate property based tests?
• If appropriate, are there adequate unit tests?
• Should any logging, debugging, tracing information be added or removed?
• Are error messages user-friendly?
• Have all documentation changes needed been made?
• Have all non-obvious changes been commented?

System Compatibility

• Are there any potential impacts on other parts of the system or backward compatibility?
• Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

• Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

[propel-code-bot]

Map closed-channel error to Error::LogContentionFailure

Single-line bug fix in ManifestManager to return the semantically correct Error::LogContentionFailure instead of a generic Error::internal when an internal oneshot channel closes during log-contention scenarios. This provides clearer error propagation for callers that already expect contention-specific failures.

Key Changes

• Replaced Err(_) => Err(Error::internal(file!(), line!())) with Err(_) => Err(Error::LogContentionFailure) in rust/wal3/src/manifest_manager.rs

Affected Areas

• publish_fragment error mapping inside ManifestManager

This summary was automatically generated by @propel-code-bot