feat(CCHAIN-740): Implement validator proof protocol per ADR-006 by ancazamfir · Pull Request #1450 · circlefin/malachite

ancazamfir · 2026-02-04T12:52:55Z

Implementation of #1436

Uses libp2p-stream protocol to satisfy the protocol spec and as proposed by @romac

code/crates/core-types/src/validator_proof.rs

ancazamfir · 2026-02-28T20:52:54Z

For testing I used the example/channel app, init and started nodes wiht testnet_manager.bash script.
Current settings in the script:

    export MALACHITE__CONSENSUS__P2P__PROTOCOL__TYPE="gossipsub"
    export MALACHITE__CONSENSUS__P2P__PROTOCOL__ENABLE_PEER_SCORING="false"
    export MALACHITE__VALIDATOR_ROTATION__ENABLED="true"
    export MALACHITE__VALIDATOR_ROTATION__ROTATION_PERIOD="10"
    export MALACHITE__VALIDATOR_ROTATION__SELECTION_SIZE="3"
    export MALACHITE__CONSENSUS__P2P__PROTOCOL__ENABLE_EXPLICIT_PEERING="false"
    export MALACHITE__CONSENSUS__P2P__PROTOCOL__ENABLE_FLOOD_PUBLISH="true"

With these settings the validator set rotates every 10 heights and 3 validators are selected from the validators crates.

Testing uses the metrics to determine node classification, for this PR the validator vs persistent or full-node is of interest. Used check_mesh_vals.py to get and process the metrics.

init and start the nodes

./scripts/testnet_manager.bash init --validators 5 --full-nodes 10 --home nodes
./scripts/testnet_manager.bash start --nodes all --home node

check the node types, verify that every 10 heights the nodes are properly (re)classified after validator rotation

...
Moniker         Type         Cons  Prop  Live  Expl  Peers  InPeers  OutPeers  Conns  InConns  OutConns
-----------------------------------------------------------------------------------------------------------------------------
app-1           validator    11    11    11    0     11     7        4         15     11       4
app-2           validator    10    8     11    0     11     7        4         15     11       4
app-3           validator    6     11    7     0     11     7        4         15     11       4
-----------------------------------------------------------------------------------------------------------------------------
app-0           persistent   11    11    11    0     11     7        4         15     11       4
app-4           persistent   10    7     8     0     11     7        4         15     11       4
-----------------------------------------------------------------------------------------------------------------------------
app-10          full_node    4     4     4     0     5      0        5         5      0        5
app-11          full_node    4     4     4     0     5      0        5         5      0        5
app-5           full_node    4     4     4     0     5      0        5         5      0        5
app-6           full_node    4     4     4     0     5      0        5         5      0        5
app-7           full_node    4     4     4     0     5      0        5         5      0        5
app-8           full_node    4     4     4     0     5      0        5         5      0        5
app-9           full_node    4     4     4     0     5      0        5         5      0        5

Wrap the proof read in a 5-second timeout to prevent a malicious or buggy peer from holding substreams open indefinitely by never sending data. On timeout, the reader is dropped which closes the substream. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Cover the critical code paths in the proof-of-validator protocol: - Behaviour: poll state machine (anti-spam, retry-on-failure), connection tracking (first/additional/partial/full close), and send_proof logic - State: record_verified_proof, reclassify_peers via process_validator_set_update, local node reclassification, and persistent peer + proof interaction Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

nenadmilosevic95

Made a full code pass, and the code looks good! Left some comments, most are minor, some we can maybe discuss! Didn't run any tests, plan to do this on Monday!

code/crates/network/src/validator_proof/README.md

code/crates/core-types/src/validator_proof.rs

code/crates/network/src/validator_proof/types.rs

code/crates/network/src/validator_proof/behaviour.rs

code/crates/network/src/state.rs

code/crates/network/src/lib.rs

code/crates/signing/src/ext.rs

BREAKING_CHANGES.md

Co-authored-by: nenadmilosevic95 <nenad.milosevic@circle.com>

…ction counters

romac

Amazing work 🚀

nenadmilosevic95

Awesome work! Left 3 nitpicks, feel free to ignore!

code/crates/signing/src/ext.rs

code/crates/network/src/validator_proof/behaviour.rs

nenadmilosevic95 · 2026-03-10T08:59:33Z

code/crates/network/src/validator_proof/behaviour.rs

+            match &event {
+                // On send failure, allow retry by removing from sent set
+                Event::ProofSendFailed { peer, .. } => {
+                    self.proofs_sent.remove(peer);


Ok, let's skip it for now

Co-authored-by: nenadmilosevic95 <nenad.milosevic@circle.com>

ancazamfir added 2 commits February 4, 2026 13:46

Implement validator proof protocol per ADR-006

388762e

Refactor metrics

61ac08c

adizere reviewed Feb 18, 2026

View reviewed changes

code/crates/core-types/src/validator_proof.rs Show resolved Hide resolved

ancazamfir added 11 commits February 23, 2026 11:25

Merge branch 'main' into validator-proof

9e48ac6

Cargo fmt

3ffc58e

Make validator proof protocol name configurable

cce504e

Merge remote-tracking branch 'origin/main' into validator-proof

a9e388f

Add upgrade strategy

5e92652

Fix engine builder merge issues, cleanup

3825987

Build local nodes's validator proof in the app

8dd74c6

Fix merge mistake, update docs

e619d73

More cleanup after merge

1522054

Send the proof on start and don't wait for first height

6f15d32

Don't disconnect on codec failures, update docs

05d60bc

ancazamfir marked this pull request as ready for review February 27, 2026 22:44

ancazamfir requested a review from romac as a code owner February 27, 2026 22:44

ancazamfir requested a review from nenadmilosevic95 February 27, 2026 22:44

ancazamfir added 2 commits February 28, 2026 00:31

Merge branch 'main' into validator-proof

86cbd61

Cleanup after merge

b1e5552

romac and others added 9 commits March 3, 2026 10:40

Rename VerificationResult to ProofVerificationResult

658a66a

Sort validators and peers in NetworkStateDump

aad002e

Add command and log message in start_listening

94da4bc

Use "separator" in ADR instead of "prefix"

44b47ae

Avoid a few cheap clones of proof bytes

79f954b

Rename certificate to proof in a couple places

7632f54

Add note when polling inner behavior

a0a21cf

nenadmilosevic95 reviewed Mar 6, 2026

View reviewed changes

ancazamfir and others added 5 commits March 9, 2026 12:21

Apply suggestions from code review

020fba8

Co-authored-by: nenadmilosevic95 <nenad.milosevic@circle.com>

Replace connections/proofs_sent tracking with libp2p's built-in conne…

148c46d

…ction counters

Fix description of proof_bytes

71e351d

Add test for proof arriving before Identify completes

63f7151

Merge branch 'main' into validator-proof

1c1c9bd

romac previously approved these changes Mar 9, 2026

View reviewed changes

nenadmilosevic95 approved these changes Mar 10, 2026

View reviewed changes

Apply suggestions from code review

824d694

Co-authored-by: nenadmilosevic95 <nenad.milosevic@circle.com>

ancazamfir dismissed romac’s stale review via 824d694 March 10, 2026 09:06

romac approved these changes Mar 10, 2026

View reviewed changes

ancazamfir added this pull request to the merge queue Mar 10, 2026

Merged via the queue into circlefin:main with commit b6f55de Mar 10, 2026
12 checks passed

ancazamfir deleted the validator-proof branch March 10, 2026 09:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(CCHAIN-740): Implement validator proof protocol per ADR-006#1450

feat(CCHAIN-740): Implement validator proof protocol per ADR-006#1450
ancazamfir merged 30 commits intocirclefin:mainfrom
ancazamfir:validator-proof

ancazamfir commented Feb 4, 2026 •

edited by romac

Loading

Uh oh!

Uh oh!

ancazamfir commented Feb 28, 2026 •

edited

Loading

Uh oh!

nenadmilosevic95 left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

romac left a comment

Uh oh!

nenadmilosevic95 left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nenadmilosevic95 Mar 10, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

ancazamfir commented Feb 4, 2026 • edited by romac Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

ancazamfir commented Feb 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nenadmilosevic95 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

romac left a comment

Choose a reason for hiding this comment

Uh oh!

nenadmilosevic95 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nenadmilosevic95 Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ancazamfir commented Feb 4, 2026 •

edited by romac

Loading

ancazamfir commented Feb 28, 2026 •

edited

Loading