Skip to content

Conversation

@AntoineCDussault
Copy link

@AntoineCDussault AntoineCDussault commented Dec 7, 2025

CSL Styles Pull Request Template

You're about to create a pull request to the CSL styles repository.
If you haven't done so already, see https://github.com/citation-style-language/styles/blob/master/CONTRIBUTING.md for instructions on how to contribute, and https://github.com/citation-style-language/styles/blob/master/STYLE_REQUIREMENTS.md for the requirements a style must meet before acceptance.
In addition, please fill out the pull request template below.

Description

(Briefly describe the style or changes you're proposing.)

Checklist

  • Check that you've added a link to the style you used as a template in the <info> block at the beginning of the file with rel="template".
  • Check that you've added a link to the style guidelines with rel="documentation".
  • Check that you've added yourself as the <author> of the style or <contributor> for a style update.
  • Check that you've used the correct terms or labels instead of hardcoding into affixes (e.g., <text variable="page" prefix="pp. "/>).
  • Check that you've not used <text value="... if not absolutely necessary.
  • Check that you've not changed line 1 of the style.

@github-actions
Copy link

github-actions bot commented Dec 7, 2025

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing:

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@AntoineCDussault
Copy link
Author

I originally had misspelled the file name (missin - between de and metaphysique.

@github-actions
Copy link

github-actions bot commented Dec 7, 2025

😟 There are some issues with your submission.

1 test failed

revue-demetaphysique-et-de-morale: style ID must be of the form "http://www.zotero.org/styles/" + style file name (without ".csl" extension, e.g. "http://www.zotero.org/styles/apa")

expected: "http://www.zotero.org/styles/revue-demetaphysique-et-de-morale"
     got: "http://www.zotero.org/styles/revue-de-metaphysique-et-de-morale"

(compared using ==)

Please check the test report for details.

@AntoineCDussault AntoineCDussault changed the title Create revue-demetaphysique-et-de-morale.csl Create revue-de-metaphysique-et-de-morale.csl Dec 7, 2025
@AntoineCDussault
Copy link
Author

I think I made the needed correction. Do I need to re-submit a pull request?

@POBrien333
Copy link
Contributor

I assume Laurent Jaffro was the author of the template style?
Please add the template link to the style (see the doucmentation/checklist in the opening post.
Then also make yourself the author of this style and remove the previous author.

@github-actions github-actions bot added the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Dec 8, 2025
@github-actions
Copy link

github-actions bot commented Dec 8, 2025

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

revue-de-metaphysique-et-de-morale.csl (new)
B.  Hancké, M.  Rhodes, M.  Thatcher (dir.), Beyond varieties of capitalism: Conflict, contradictions, and complementarities in the European economy, Oxford, Oxford University Press, 2007 ; « CSL search by example », Citation style editor, 2012, http://editor.citationstyles.org/searchByExample/.
I.  Mares, « Firms and the welfare state: When, why, and how does social policy matter to employers? », Oxford, Oxford University Press, 2001, p. 184‑212 ; M.  Fenner, M.  Crosas, J. S.  Grethe, D.  Kennedy, H.  Hermjakob, P.  Rocca-Serra, G.  Durand, R.  Berjon, S.  Karcher, M.  Martone, T.  Clark, 2019, 6 (1), p. 28.


Fenner M. , Crosas M. , Grethe J. S. , Kennedy D. , Hermjakob H. , Rocca-Serra P. , Durand G. , Berjon R. , Karcher S. , Martone M. , Clark T. , « A data citation roadmap for scholarly data repositories », Scientific Data, 2019, 6 (1), p. 28.
Hancké B., Rhodes M., Thatcher M. (dir.), Beyond varieties of capitalism: Conflict, contradictions, and complementarities in the European economy, Oxford, Oxford University Press, 2007.
Mares I. , « Firms and the welfare state: When, why, and how does social policy matter to employers? », in P. A.  Hall, D.  Soskice (dir.), Varieties of capitalism: The institutional foundations of comparative advantage, Oxford, Oxford University Press, 2001, p. 184‑212.

@AntoineCDussault
Copy link
Author

In fact, Jaffro is coauthor of the style. He is the editor of the journal. I asked if the journal had a zotero style, and in response he sent me a style he had started working on. The style had many mistakes however, so I made improvements to it. I worked from his file, so I don't know if he used a template.

@github-actions github-actions bot removed the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Dec 8, 2025
</group>
</macro>
<macro name="editor">
<text value="in" font-style="italic" suffix=" " prefix=" "/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace with a term and put the term and names variable into a group and set the space there as a delimiter.

</else-if>
<else-if type="thesis" match="any">
<group>
<text variable="title" text-case="capitalize-first" font-style="italic" suffix=","/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these ", " suffixes can be set on the group level and then removed on the elements.

</else-if>
<else-if type="chapter entry-dictionary entry-encyclopedia" match="any">
<group>
<group font-style="normal" suffix=",">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please go through the style and remove and "normal" that don't serve any purpose.

<group>
<text term="volume" form="short" suffix=".&#160;"/>
<text variable="number-of-volumes" prefix=". " suffix="/"/>
<text variable="volume"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you have a ". " suffix on volume and a ". " prefix on number-of-volumes. Is that on purpose?

<text variable="volume"/>
</group>
<choose>
<if variable="locator" match="any">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this whole "if" can be simplified to a group with locator label+variable.

<group delimiter=" " font-style="normal">
<choose>
<if variable="locator" match="any">
<text variable="locator" prefix="p.&#160;"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use a label instead of hardcoding the "p. "

@POBrien333 POBrien333 added the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Dec 10, 2025
@github-actions
Copy link

😃 Your submission passed all our automated tests.

Below are some sample citations generated based on your proposed changes:

revue-de-metaphysique-et-de-morale.csl (new)
B.  Hancké, M.  Rhodes, M.  Thatcher (dir.), Beyond varieties of capitalism: Conflict, contradictions, and complementarities in the European economy, Oxford, Oxford University Press, 2007 ; « CSL search by example », Citation style editor, 2012, http://editor.citationstyles.org/searchByExample/.
I.  Mares, « Firms and the welfare state: When, why, and how does social policy matter to employers? », Oxford, Oxford University Press, 2001, p. 184‑212 ; M.  Fenner, M.  Crosas, J. S.  Grethe, D.  Kennedy, H.  Hermjakob, P.  Rocca-Serra, G.  Durand, R.  Berjon, S.  Karcher, M.  Martone, T.  Clark, 2019, 6 (1), p. 28.


Fenner M. , Crosas M. , Grethe J. S. , Kennedy D. , Hermjakob H. , Rocca-Serra P. , Durand G. , Berjon R. , Karcher S. , Martone M. , Clark T. , « A data citation roadmap for scholarly data repositories », Scientific Data, 2019, 6 (1), p. 28.
Hancké B., Rhodes M., Thatcher M. (dir.), Beyond varieties of capitalism: Conflict, contradictions, and complementarities in the European economy, Oxford, Oxford University Press, 2007.
Mares I. , « Firms and the welfare state: When, why, and how does social policy matter to employers? », in P. A.  Hall, D.  Soskice (dir.), Varieties of capitalism: The institutional foundations of comparative advantage, Oxford, Oxford University Press, 2001, p. 184‑212.

@AntoineCDussault
Copy link
Author

I think I successfully made all the requested change, instead for one: removing the "normal" that serve no purpose. I'm working exclusively through the Visual style editor, so I'm a little puzzled as to how I'd do it. Also, Jaffro is in fact coauthor of the style. He is the editor of the journal. I asked if the journal had a zotero style, and in response he sent me a style he had started working on. The style had many mistakes however, so I made improvements to it. I worked from his file, so I don't know if he used a template.

@github-actions github-actions bot removed the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Dec 10, 2025
@POBrien333
Copy link
Contributor

You can just go to edit and then remove the code, so delete font-style="normal" completeley.

@github-actions github-actions bot added the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Dec 10, 2025
@AntoineCDussault
Copy link
Author

I can delete it everywhere or I need to know where its purposeless and where it is purposeful?

@github-actions github-actions bot removed the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Dec 10, 2025
@POBrien333
Copy link
Contributor

You can look at the output of the style.
Usually they are useless and only in certain cases serve a purpose. For example you want everything in italics, but then want to "unset" a part to not have italics. A reverse UNO so to speak.

@github-actions github-actions bot added the waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor label Dec 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-for-response-from-contributor The ticket/pull request is awaiting input from the contributor/depositor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants