-
-
Notifications
You must be signed in to change notification settings - Fork 4k
Create revue-de-metaphysique-et-de-morale.csl #7941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Create revue-de-metaphysique-et-de-morale.csl #7941
Conversation
|
Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes. If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements. To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing: If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable. |
|
I originally had misspelled the file name (missin - between de and metaphysique. |
|
😟 There are some issues with your submission. 1 test failedrevue-demetaphysique-et-de-morale: style ID must be of the form "http://www.zotero.org/styles/" + style file name (without ".csl" extension, e.g. "http://www.zotero.org/styles/apa") Please check the test report for details. |
|
I think I made the needed correction. Do I need to re-submit a pull request? |
|
I assume Laurent Jaffro was the author of the template style? |
|
😃 Your submission passed all our automated tests. Below are some sample citations generated based on your proposed changes: revue-de-metaphysique-et-de-morale.csl (new)B. Hancké, M. Rhodes, M. Thatcher (dir.), Beyond varieties of capitalism: Conflict, contradictions, and complementarities in the European economy, Oxford, Oxford University Press, 2007 ; « CSL search by example », Citation style editor, 2012, http://editor.citationstyles.org/searchByExample/. |
|
In fact, Jaffro is coauthor of the style. He is the editor of the journal. I asked if the journal had a zotero style, and in response he sent me a style he had started working on. The style had many mistakes however, so I made improvements to it. I worked from his file, so I don't know if he used a template. |
| </group> | ||
| </macro> | ||
| <macro name="editor"> | ||
| <text value="in" font-style="italic" suffix=" " prefix=" "/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replace with a term and put the term and names variable into a group and set the space there as a delimiter.
| </else-if> | ||
| <else-if type="thesis" match="any"> | ||
| <group> | ||
| <text variable="title" text-case="capitalize-first" font-style="italic" suffix=","/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these ", " suffixes can be set on the group level and then removed on the elements.
| </else-if> | ||
| <else-if type="chapter entry-dictionary entry-encyclopedia" match="any"> | ||
| <group> | ||
| <group font-style="normal" suffix=","> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please go through the style and remove and "normal" that don't serve any purpose.
| <group> | ||
| <text term="volume" form="short" suffix=". "/> | ||
| <text variable="number-of-volumes" prefix=". " suffix="/"/> | ||
| <text variable="volume"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you have a ". " suffix on volume and a ". " prefix on number-of-volumes. Is that on purpose?
| <text variable="volume"/> | ||
| </group> | ||
| <choose> | ||
| <if variable="locator" match="any"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this whole "if" can be simplified to a group with locator label+variable.
| <group delimiter=" " font-style="normal"> | ||
| <choose> | ||
| <if variable="locator" match="any"> | ||
| <text variable="locator" prefix="p. "/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use a label instead of hardcoding the "p. "
|
😃 Your submission passed all our automated tests. Below are some sample citations generated based on your proposed changes: revue-de-metaphysique-et-de-morale.csl (new)B. Hancké, M. Rhodes, M. Thatcher (dir.), Beyond varieties of capitalism: Conflict, contradictions, and complementarities in the European economy, Oxford, Oxford University Press, 2007 ; « CSL search by example », Citation style editor, 2012, http://editor.citationstyles.org/searchByExample/. |
|
I think I successfully made all the requested change, instead for one: removing the "normal" that serve no purpose. I'm working exclusively through the Visual style editor, so I'm a little puzzled as to how I'd do it. Also, Jaffro is in fact coauthor of the style. He is the editor of the journal. I asked if the journal had a zotero style, and in response he sent me a style he had started working on. The style had many mistakes however, so I made improvements to it. I worked from his file, so I don't know if he used a template. |
|
You can just go to edit and then remove the code, so delete |
|
I can delete it everywhere or I need to know where its purposeless and where it is purposeful? |
|
You can look at the output of the style. |

CSL Styles Pull Request Template
You're about to create a pull request to the CSL styles repository.
If you haven't done so already, see https://github.com/citation-style-language/styles/blob/master/CONTRIBUTING.md for instructions on how to contribute, and https://github.com/citation-style-language/styles/blob/master/STYLE_REQUIREMENTS.md for the requirements a style must meet before acceptance.
In addition, please fill out the pull request template below.
Description
(Briefly describe the style or changes you're proposing.)
Checklist
<info>block at the beginning of the file withrel="template".rel="documentation".<author>of the style or<contributor>for a style update.<text variable="page" prefix="pp. "/>).<text value="...if not absolutely necessary.