Conversation
…eload ECS Services Page AutoReload
|
Code Review for PR 175 (custom/ecs/clusters/render.go +AutoReload:true on Services nav). GOOD: consistent with cloudformation/stacks pattern, correct wiring via render.Navigation into NewResourceBrowserWithAutoReload, sensible UX rationale. CONCERNS: (1) tasks nav lacks AutoReload despite similar churn - consider aligning or documenting; (2) PR title is branch name Develop with empty body - needs descriptive title and motivation; (3) no tests updated. VERDICT: correct, benign, one-line change with no regression risk. Ship after addressing metadata and considering tasks nav. |
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Mar 9, 2026
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [github:clawscli/claws](https://github.com/clawscli/claws) | patch | `0.15.1` → `0.15.2` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>clawscli/claws (github:clawscli/claws)</summary> ### [`v0.15.2`](https://github.com/clawscli/claws/releases/tag/v0.15.2) [Compare Source](clawscli/claws@v0.15.1...v0.15.2) #### Changelog - [`c982865`](clawscli/claws@c982865) Merge branch 'main' into dependabot/github\_actions/actions/upload-artifact-7 - [`0bcdb4a`](clawscli/claws@0bcdb4a) Merge pull request [#​171](clawscli/claws#171) from clawscli/dependabot/github\_actions/goreleaser/goreleaser-action-7 - [`52cd2c9`](clawscli/claws@52cd2c9) Merge pull request [#​172](clawscli/claws#172) from dpalvolgyi-pw/feature/ecs-services-autoreload - [`c291dd6`](clawscli/claws@c291dd6) Merge pull request [#​173](clawscli/claws#173) from clawscli/dependabot/github\_actions/actions/upload-artifact-7 - [`24b119a`](clawscli/claws@24b119a) Merge pull request [#​175](clawscli/claws#175) from clawscli/develop - [`f8c482c`](clawscli/claws@f8c482c) ci: bump actions/upload-artifact from 6 to 7 - [`92bc391`](clawscli/claws@92bc391) ci: bump goreleaser/goreleaser-action from 6 to 7 - [`a9d5e0a`](clawscli/claws@a9d5e0a) feat(ecs): auto-reload ecs services page </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My41Ny4wIiwidXBkYXRlZEluVmVyIjoiNDMuNTcuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90IiwiYXV0b21hdGlvbjpib3QtYXV0aG9yZWQiLCJkZXBlbmRlbmN5LXR5cGU6OnBhdGNoIl19-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.