Skip to content

fix(clerk-js,localizations,types): Add formFieldHintText__slug key #1811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LekoArts merged 3 commits into from
Oct 2, 2023
Merged

fix(clerk-js,localizations,types): Add formFieldHintText__slug key #1811

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
228d0dd
fix(clerk-js,localizations,types): Add `formFieldHintText__slug` key
LekoArts Oct 2, 2023
0760315
fix(localizations): Add german translation
LekoArts Oct 2, 2023
c6ff3ab
Create cyan-pots-invite.md
LekoArts Oct 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/cyan-pots-invite.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"@clerk/clerk-js": patch
"@clerk/localizations": patch
"@clerk/types": patch
---

Enables you to translate the tooltip hint while creating an organization through the `formFieldHintText__slug` key
2 changes: 1 addition & 1 deletion packages/clerk-js/src/ui/elements/FormControl.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,7 @@ export const FormControl = forwardRef<HTMLInputElement, PropsWithChildren<FormCo
const Icon = icon ? (
<Flex
as={'span'}
title='A slug is a human-readable ID that must be unique.  It’s often used in URLs.'
title={t(localizationKeys('formFieldHintText__slug'))}
Copy link
Contributor

@panteliselef panteliselef Oct 2, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about this instead ?

Suggested change
title={t(localizationKeys('formFieldHintText__slug'))}
title={t(localizationKeys('formFieldIconText__organizationSlug'))}

Copy link
Contributor Author

@LekoArts LekoArts Oct 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to reuse this in other places, hintText__slug is more generic and appropriate than tying this specific to organizations. The text isn't mentioning Organizations

>
<IconCustomizable
icon={icon}
Expand Down
2 changes: 2 additions & 0 deletions packages/localizations/src/de-DE.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ export const deDE: LocalizationResource = {
'Der Bestätigungslink ist abgelaufen. Bitte fordern Sie einen neuen Link an.',
formFieldAction__forgotPassword: 'Passwort vergessen?',
formFieldHintText__optional: 'Optional',
formFieldHintText__slug:
'Der Slug ist eine für Menschen lesbare ID. Sie muss einzigartig sein und wird oft in URLs verwendet.',
formButtonPrimary: 'Fortsetzen',
signInEnterPasswordTitle: 'Geben Sie Ihr Passwort ein',
backButton: 'Zurück',
Expand Down
1 change: 1 addition & 0 deletions packages/localizations/src/en-US.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ export const enUS: LocalizationResource = {
formFieldError__verificationLinkExpired: 'The verification link expired. Please request a new link.',
formFieldAction__forgotPassword: 'Forgot password?',
formFieldHintText__optional: 'Optional',
formFieldHintText__slug: 'A slug is a human-readable ID that must be unique. It’s often used in URLs.',
formButtonPrimary: 'Continue',
signInEnterPasswordTitle: 'Enter your password',
backButton: 'Back',
Expand Down
1 change: 1 addition & 0 deletions packages/types/src/localization.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ type _LocalizationResource = {
formFieldError__verificationLinkExpired: LocalizationValue;
formFieldAction__forgotPassword: LocalizationValue;
formFieldHintText__optional: LocalizationValue;
formFieldHintText__slug: LocalizationValue;
formButtonPrimary: LocalizationValue;
signInEnterPasswordTitle: LocalizationValue;
backButton: LocalizationValue;
Expand Down