feat(clerk-js,localizations): Nav to reset-password if needs_new_password#2984
Merged
nikosdouvlis merged 2 commits intomainfrom Mar 19, 2024
Merged
Conversation
🦋 Changeset detectedLatest commit: d45314e The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
yourtallness
force-pushed
the
yourtallness/password_complexity_strength_on_sign_in
branch
from
dba312a to
a4b140d
Compare
…if sign_in.needs_new_password If password_settings.enforce_on_sign_in is true, then it will be possible for a password sign-in to succeed but require a new password that conforms to updated password requirements. Hence, if sign_in.needs_new_password is true, the password form will navigate to reset-password. Since we are reusing a flow initially created for resetting passwords after an oauth flow, the error message has been made more generic.
clerk-cookie
added
actions
backend
chrome-extension
integration
and removed
localizations
labels
Member
|
!preview |
octoper
added
localizations
and removed
actions
backend
chrome-extension
integration
labels
Collaborator
|
Hey @octoper, your preview is available.
|
yourtallness
force-pushed
the
yourtallness/password_complexity_strength_on_sign_in
branch
from
a4b140d to
de1336c
Compare
LekoArts
changed the title
reset-password from pass-form …reset-password if needs_new_password
LekoArts
reviewed
Mar 13, 2024
panteliselef
approved these changes
Mar 14, 2024
Contributor
panteliselef
left a comment
panteliselef
left a comment
There was a problem hiding this comment.
Looks good, just update the changeset file as @LekoArts suggested
Co-authored-by: Lennart <lekoarts@gmail.com>
nikosdouvlis
approved these changes
Mar 19, 2024
nikosdouvlis
deleted the
yourtallness/password_complexity_strength_on_sign_in
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If password_settings.enforce_on_sign_in is true, then it will be possible for a password sign-in to succeed but require a new password that conforms to updated password requirements.
Hence, if sign_in.needs_new_password is true, the password form will navigate to reset-password.
Since we are reusing a flow initially created for resetting passwords after an oauth flow, the error message has been made more generic.
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change