feat(clerk-expo): Add secure token cache implementation and rename secureStore#5375
Merged
wobsoriano merged 22 commits intomainfrom Mar 18, 2025
Merged
feat(clerk-expo): Add secure token cache implementation and rename secureStore#5375wobsoriano merged 22 commits intomainfrom
secureStore#5375wobsoriano merged 22 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 81c632a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
secureStore
anagstef
reviewed
Mar 18, 2025
Comment on lines
-103
to
-105
| }, | ||
| "expo-secure-store": { | ||
| "optional": true |
Member
There was a problem hiding this comment.
We should remove this in the next major, because if someone is not using this package they will get errors when updating their package.
Member
Author
There was a problem hiding this comment.
Good catch and I agree. Updated. thanks!
panteliselef
suggested changes
Mar 18, 2025
Contributor
panteliselef
left a comment
There was a problem hiding this comment.
Seems like we are not deprecating properly. And we are introducing breaking changes since secureStore is no longer exported from the expected path.
| const item = await SecureStore.getItemAsync(key); | ||
| return item; | ||
| } catch (error) { | ||
| console.error('Clerk: Failed to retrieve token from SecureStore:', error); |
25b7130 to
e539a3c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a default secure token cache (basically what's in our quickstart) and deprecates
secureStorein favor ofresourceCachefor the experimental offline support.Resolves ECO-510
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change