Skip to content

Bump StackExchange.Redis from 2.9.32 to 2.10.1 #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
happymancoder merged 2 commits into from
Dec 3, 2025
Merged

Bump StackExchange.Redis from 2.9.32 to 2.10.1 #386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3da1d74
Bump StackExchange.Redis from 2.9.32 to 2.10.1
dependabot[bot] Dec 2, 2025
056cb88
Update RedisUserSessionStore with changes from new nuget package
MrSmoke Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ExchangeRedis/src/ClickView.GoodStuff.AspNetCore.Authentication.StackExchangeRedis.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

<ItemGroup>
<PackageReference Include="Microsoft.Extensions.Options" Version="10.0.0" />
<PackageReference Include="StackExchange.Redis" Version="2.9.32" />
<PackageReference Include="StackExchange.Redis" Version="2.10.1" />
<PackageReference Include="System.Text.Json" Version="10.0.0" />
</ItemGroup>

Expand Down
17 changes: 0 additions & 17 deletions src/AspNetCore/Authentication/StackExchangeRedis/src/DateTimeOffsetExtensions.cs
View file
Open in desktop

This file was deleted.

8 changes: 5 additions & 3 deletions src/AspNetCore/Authentication/StackExchangeRedis/src/RedisUserSessionStore.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,12 +113,14 @@ public async Task DeleteBySessionIdAsync(string sessionId, CancellationToken tok

private void AddInternal(ITransaction transaction, string key, UserSession session)
{
var expireTimeSpan = session.Expiry?.ToRedisExpiryTimeSpan();
var expiration = session.Expiry.HasValue
? new Expiration(session.Expiry.Value.UtcDateTime)
: default;

_ = transaction.StringSetAsync(_keyPrefix.Append(key), Serialize(session), expireTimeSpan);
_ = transaction.StringSetAsync(_keyPrefix.Append(key), Serialize(session), expiry: expiration);

if (!string.IsNullOrWhiteSpace(session.SessionId))
_ = transaction.StringSetAsync(GetSessionIdKey(session.SessionId), session.Key, expireTimeSpan);
_ = transaction.StringSetAsync(GetSessionIdKey(session.SessionId), session.Key, expiry: expiration);
}

private static UserSession? Deserialize(byte[] value) => JsonSerializer.Deserialize<UserSession>(value);
Expand Down
19 changes: 8 additions & 11 deletions src/AspNetCore/Authentication/StackExchangeRedis/test/RedisUserSessionStoreTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,21 +174,18 @@ public async Task Can_Expire_UserSession_Key()

[SkippableFact]
[SkipOnCI(SkipCiReason)]
public async Task Add_Expired_Session_ThrowsException()
public async Task Add_Expired_Session_DoesNotThrow()
{
await Assert.ThrowsAsync<Exception>(async () =>
var session = new UserSession("6", [1, 2])
{
var session = new UserSession("6", [1, 2])
{
SessionId = "sessionId6",
Subject = "subject6",
Expiry = DateTimeOffset.UtcNow.AddSeconds(-10)
};
SessionId = "sessionId6",
Subject = "subject6",
Expiry = DateTimeOffset.UtcNow.AddSeconds(-10)
};

var sessionStore = await GetUserSessionStoreAsync();
var sessionStore = await GetUserSessionStoreAsync();

await sessionStore.AddAsync(session, CancellationToken.None);
});
await sessionStore.AddAsync(session, CancellationToken.None);
}

private static async Task<IUserSessionStore> GetUserSessionStoreAsync(
Expand Down