Fix json name mapping for milliSat#57
Merged
vincenzopalazzo merged 2 commits intoclightning4j:masterfrom Oct 11, 2021
hsteinmueller:bug/json_name_mapping
Merged
Fix json name mapping for milliSat#57vincenzopalazzo merged 2 commits intoclightning4j:masterfrom hsteinmueller:bug/json_name_mapping
vincenzopalazzo merged 2 commits intoclightning4j:masterfrom
hsteinmueller:bug/json_name_mapping
Conversation
vincenzopalazzo
requested changes
Oct 11, 2021
Member
vincenzopalazzo
left a comment
vincenzopalazzo
left a comment
There was a problem hiding this comment.
LGTM, thanks for your amazing work :) and also for the help
I have only a small request.
vincenzopalazzo
approved these changes
Oct 11, 2021
Member
vincenzopalazzo
left a comment
vincenzopalazzo
left a comment
There was a problem hiding this comment.
Thanks for your work!
@vincenzopalazzo review this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #56, fixed the mapping as described.