Display Node and Doctor version in generated Doctor view #324
Conversation
index.js
Outdated
| .on('end', () => { | ||
| fs.writeFile(systemInfoPath, chunks.toString(), 'utf-8', function () { | ||
| }) | ||
| }) |
There was a problem hiding this comment.
Why this instead of just copying the file? The other (and more efficient way of doing this if it's really needed is to just pipe from one stream to another...)
const in = fs.createReadStream(paths['/systeminfo'])
const out = fs.createWriteStream(systemInfoPath)
stream.pipeline(in, out, (err) => {
if (err) /** handle the error **/
})There was a problem hiding this comment.
Really tho, I'm just not sure why this copy is necessary at all
There was a problem hiding this comment.
Yeah, I see that, it's not a very good solution, it was originally a problem with accessing the data file. But I've updated it there.
|
Good start. Please also be sure to include the command line arguments used to launch clinic |
|
We can add the necessary systemInfo data to the |
goto-bus-stop
left a comment
goto-bus-stop
left a comment
There was a problem hiding this comment.
oops…had review comments still in the queue…don't know if you'll have time for this anymore, no matter either way :)
3 participants
No description provided.