Skip to content

make case when nil is a string #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hlolli wants to merge 2 commits into from
Closed

make case when nil is a string #80

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83980ff
make case when nil is a string
hlolli Jun 2, 2017
1050c1d
fix eldoc for lumo mode and completion collisions
hlolli Jun 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions inf-clojure.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -703,7 +703,8 @@ If you are using REPL types, it will pickup the most approapriate
(define-obsolete-variable-alias 'inf-clojure-arglist-command 'inf-clojure-arglists-form "2.0.0")

(defcustom inf-clojure-arglists-form-lumo
"(pr-str (lumo.repl/get-arglists \"%s\"))"
"(when-let [res (lumo.repl/get-arglists \"%s\")]
(-> res str clojure.string/trim))"
"Lumo form to query inferior Clojure for a function's arglists."
:type 'string
:package-version '(inf-clojure . "2.0.0"))
Expand Down Expand Up @@ -982,7 +983,9 @@ See variable `inf-clojure-arglists-form'."
(cond
((null arglists-data) nil)
((stringp arglists-data) arglists-data)
((listp arglists-data) arglists-result))))
Copy link
Contributor

@arichiardi arichiardi Jun 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember why I was returning the result here, it looks like I should return the read data...Uhm..

((and (listp arglists-data)
(not (string-equal inf-clojure-repl-type "lumo")))
arglists-result))))

(defun inf-clojure-show-arglists (prompt-for-symbol)
"Show the arglists for function FN in the mini-buffer.
Expand Down